kvazaar: fix on <10.7

[barracuda156]

Description

Blacklist archaic gcc which fail to build this. This fixes 10.5 and 10.6 with libstdc++.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?
• checked your Portfile with port lint --nitpick?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?
• checked that the Portfile's most important variants haven't been broken?

[macportsbot]

Notifying maintainers:
@mohd-akram for port kvazaar.

[mohd-akram]

I run the tests and get this:

PASS: kvazaar_tests
FAIL: test_external_symbols.sh
FAIL: test_gop.sh
FAIL: test_interlace.sh
FAIL: test_intra.sh
FAIL: test_invalid_input.sh
FAIL: test_mv_constraint.sh
FAIL: test_owf_wpp_tiles.sh
FAIL: test_rate_control.sh
FAIL: test_slices.sh
FAIL: test_smp.sh
FAIL: test_tools.sh
FAIL: test_weird_shapes.sh
FAIL: test_pu_depth_constraints.sh
============================================================================
Testsuite summary for kvazaar 2.3.0
============================================================================
# TOTAL: 14
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  13
# XPASS: 0
# ERROR: 0
============================================================================
See tests/test-suite.log
============================================================================

[barracuda156]

@mohd-akram Oops, this looks bad. Wonder whether something got broken now? I ran tests last time, when initially submitted a PR, and pretty much everything passed.

I will try now. (It perhaps does not hurt to have tests anyway, at least to know it is broken, but let us see what works and what does not.)

[mohd-akram]

Please try to get tracing mode working on your machine when building/testing to get consistent behavior. Looks like ffmpeg is required:

./util.sh: line 18: ffmpeg: command not found

[barracuda156]

Looks like they indeed broke the syntax of commands during tests:

usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
       mktemp [-d] [-q] [-u] -t prefix 
FAIL test_slices.sh (exit status: 1)

Let me see what went so badly wrong. Making this a draft first. (Sorry, did not expect this going wrong, since it was working fine just a couple of weeks ago.)

[barracuda156]

@mohd-akram Ah, I should have read my earlier own PR more attentively. Those additional tests are broken, see ultravideo/kvazaar#374 (they need Valgrind).
But the main tests all pass.

UPD. Let me add a test dep on FFMpeg though.

UPD2. If you prefer not to have tests, no issue, I can remove them and just leave a fix for compiler choice.

[mohd-akram]

Other tests fail too, and not due to Valgrind, but due to requiring HM which AFAICT isn't available on MacPorts. This is what I get:

./util.sh: line 18: TAppDecoderStatic: command not found

The only passing tests for me are kvazaar_tests and test_invalid_input.sh. Also, the log in the issue you link to doesn't seem to mention valgrind but a mktemp error. I think change the comment to mention specifically that only kvazaar_tests and test_invalid_input.sh are expected to pass and combine the two commits, and this should be good to merge.

[pmetzger]

@barracuda156 Tracing mode is really useful. It avoids the entire problem of unknown dependencies.

I'd suggest that you close this for now, and re-open it when the update passes tests.

[mohd-akram]

I hadn't checked earlier, but it seems the build passes on 10.6 since #22316, and it uses clang-11. Is there a reason it uses GCC on your machine?

[barracuda156]

@mohd-akram Obviously, clang can only be used and only is used on Intel with libc++. For powerpc and AFAIK 10.4–10.5 Intel current compiler settings in the portfile are wrong, gcc-4.2 will be picked, and it cannot build the port.

Let me remove tests if no one interested in that, no drama. Just fixing the build is enough.

[barracuda156]

@mohd-akram @pmetzger I removed tests support. Only a fix for compiler choice remains, which is hopefully uncontroversial.

[mohd-akram]

Thanks @barracuda156. Please adjust the commit message to match the PR title and this should be good to merge.

[barracuda156]

@mohd-akram Thank you! Done.

[barracuda156]

@reneeotten @pmetzger Could we please merge this now?