Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc: Bugfix build #27470

Merged
merged 1 commit into from
Jan 28, 2025
Merged

ghc: Bugfix build #27470

merged 1 commit into from
Jan 28, 2025

Conversation

essandess
Copy link
Contributor

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@reneeotten
Copy link
Contributor

@essandess this still fails on every CI run; please take a look

@essandess essandess force-pushed the ghc branch 2 times, most recently from c37634d to 8062cf3 Compare January 27, 2025 11:34
@essandess
Copy link
Contributor Author

@essandess this still fails on every CI run; please take a look

Thanks, I believe that this is an issue I created with the haskell_cabal.use_prebuilt ports in 3935297, specifically hadrian. This fix to PG haskell_cabal should address it.

@neverpanic
Copy link
Member

With this change, alex builds fine, but happy is broken in the same way:

:info:build Executing:  cd "/opt/local/var/macports/build/_opt_dports_devel_happy/happy/work/happy-1.20.1.1" && /opt/local/bin/cabal-prebuilt --config-file=/opt/local/var/macports/build/_opt_dports_devel_happy/happy/work/.home/.cabal/config --store-dir=/opt/local/var/macports/build/_opt_dports_devel_happy/happy/work/.home/.cabal/store build happy -j12 --builddir=/opt/local/var/macports/build/_opt_dports_devel_happy/happy/work/dist --ghc --with-compiler=/opt/local/bin/ghc --prefix=/opt/local --datadir=/opt/local/share/happy --docdir=/opt/local/share/doc/happy --htmldir=/opt/local/share/doc/happy --haddockdir=/opt/local/share/doc/happy --sysconfdir=/opt/local/etc/happy --bindir=/opt/local/bin --datadir=/opt/local/share/happy 
:debug:build system:  cd "/opt/local/var/macports/build/_opt_dports_devel_happy/happy/work/happy-1.20.1.1" && /opt/local/bin/cabal-prebuilt --config-file=/opt/local/var/macports/build/_opt_dports_devel_happy/happy/work/.home/.cabal/config --store-dir=/opt/local/var/macports/build/_opt_dports_devel_happy/happy/work/.home/.cabal/store build happy -j12 --builddir=/opt/local/var/macports/build/_opt_dports_devel_happy/happy/work/dist --ghc --with-compiler=/opt/local/bin/ghc --prefix=/opt/local --datadir=/opt/local/share/happy --docdir=/opt/local/share/doc/happy --htmldir=/opt/local/share/doc/happy --haddockdir=/opt/local/share/doc/happy --sysconfdir=/opt/local/etc/happy --bindir=/opt/local/bin --datadir=/opt/local/share/happy 
:info:build Error: [Cabal-5490]
:info:build Cannot find the program 'ghc'. User-specified path '/opt/local/bin/ghc' does not refer to an executable and the program is not on the system path.

@jrabinow
Copy link
Contributor

I also have:

  • hadrian which depends on ghc binary being in the path
  • cabal which depends on ghc-pkg binary being in the path

@essandess
Copy link
Contributor Author

@reneeotten @neverpanic This fix can be merged now.

I previously added the explicit-but-likely-unnecessary flags --ghc --with-compiler= after the update to the latest cabal version to troubleshoot a CI failure on that PR.

@mascguy mascguy merged commit ba6b5b0 into macports:master Jan 28, 2025
3 checks passed
@essandess essandess deleted the ghc branch January 28, 2025 23:26
essandess added a commit to essandess/macports-ports that referenced this pull request Jan 28, 2025
essandess added a commit to essandess/macports-ports that referenced this pull request Jan 28, 2025
essandess added a commit to essandess/macports-ports that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

6 participants