Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wine-*: Fixup portfiles #27523

Merged
merged 3 commits into from
Jan 27, 2025
Merged

wine-*: Fixup portfiles #27523

merged 3 commits into from
Jan 27, 2025

Conversation

Gcenx
Copy link
Contributor

@Gcenx Gcenx commented Jan 27, 2025 •
edited
Loading

Description

Fix platform and add missing -append for MoltenVK-latest

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@Gcenx
Copy link
Contributor Author

Gcenx commented Jan 27, 2025

Currently draft as I’m currently at work and away from my any computer

@Gcenx Gcenx mentioned this pull request Jan 27, 2025
Merged
11 tasks
@jmroot jmroot marked this pull request as ready for review January 27, 2025 07:51
jmroot
jmroot approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@jmroot jmroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed and LGTM.

@jmroot jmroot merged commit f7238d7 into macports:master Jan 27, 2025
3 checks passed
@Gcenx Gcenx deleted the patch-1 branch January 27, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmroot jmroot jmroot approved these changes

Assignees
No one assigned
Labels
maintainer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gcenx @jmroot @macportsbot