Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python34: support OpenSSL 1.1 #4610

Merged
merged 1 commit into from
Jun 16, 2019
Merged

python34: support OpenSSL 1.1 #4610

merged 1 commit into from
Jun 16, 2019

Conversation

yan12125
Copy link
Contributor

Description

The patch is from python/cpython#12211. It's not
merged into official CPython 3.4 for timing reasons.

TLS functionality tested with the following script:

    try:
        import urllib.request as urllib_request
    except ImportError:
        import urllib2 as urllib_request

    h = urllib_request.urlopen('https://httpbin.org/ip')
    print(h.read().decode('utf-8'))
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.14.5 18F132
Xcode 11.0 11M336w

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

The patch is from python/cpython#12211. It's not
merged into official CPython 3.4 for timing reasons.

TLS functionality tested with the following script:

    try:
        import urllib.request as urllib_request
    except ImportError:
        import urllib2 as urllib_request

    h = urllib_request.urlopen('https://httpbin.org/ip')
    print(h.read().decode('utf-8'))
@macportsbot
Copy link

Notifying maintainers:
@jmroot for port python34.

@macportsbot macportsbot added by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: enhancement labels Jun 15, 2019
@macportsbot
Copy link

Travis Build #6907 Passed.

Lint results
--->  Verifying Portfile for python34
--->  0 errors and 0 warnings found.

Port python34 success on xcode10.2. Log
Port python34 success on xcode9.4. Log
Port python34 success on xcode8.3. Log
Port python34 success on xcode7.3. Log

@yan12125 yan12125 mentioned this pull request Jun 15, 2019
25 tasks
@cjones051073
Copy link
Member

Seems fine to me. Python 3.4 should anyway be depreciated in macports.

@jmroot jmroot merged commit b455c29 into macports:master Jun 16, 2019
@yan12125 yan12125 deleted the python34-openssl11 branch June 17, 2019 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
by: member Created by a member with commit rights maintainer: open Affects an openmaintainer port type: enhancement
Development

Successfully merging this pull request may close these issues.

4 participants