Add missing openssl dependencies

[yan12125]

Description

Some ports have files linked to libssl and/or libcrypto, but depends_lib does not include openssl, so they are missed in previous big OpenSSL upgrade (#3822). In this PR I fixed those ports to avoid further accidents.

Note that there might be more similar ports. These 4 are what I observe from commits to macports-ports after the big OpenSSL upgrade.

See individual commit messages for details, especially the one for qt*-qtlocation.

Type(s)

• bugfix
• enhancement
• security fix

Tested on

Not tested

Verification

Have you

• followed our Commit Message Guidelines?
• squashed and minimized your commits?
• checked that there aren't other open pull requests for the same change?
• referenced existing tickets on Trac with full URL?

• checked your Portfile with port lint?
• tried existing tests with sudo port test?
• tried a full install with sudo port -vst install?
• tested basic functionality of all binary files?

[macportsbot]

Notifying maintainers:
@stromnov for port py-cryptography.
@eborisch for port OpenIPMI.
@MarcusCalhoun-Lopez for port qt5, qt511, qt59.

[yan12125]

/cc @dbevans, who bumped p5-crypt-openssl-rsa

[macportsbot]

Travis Build #8368 Errored.

Lint results

--->  Verifying Portfile for qt5
Error: Line 848 repeats inclusion of PortGroup qt5
Error: Line 1583 repeats inclusion of PortGroup qmake5
Error: Line 1623 repeats inclusion of PortGroup qmake5
Error: Line 1894 repeats inclusion of PortGroup obsolete
--->  4 errors and 0 warnings found.
--->  Verifying Portfile for qt511
Error: Line 856 repeats inclusion of PortGroup qt5
Error: Line 1569 repeats inclusion of PortGroup qmake5
Error: Line 1609 repeats inclusion of PortGroup qmake5
--->  3 errors and 0 warnings found.
--->  Verifying Portfile for qt59
Error: Line 841 repeats inclusion of PortGroup qt5
Error: Line 1551 repeats inclusion of PortGroup qmake5
Error: Line 1591 repeats inclusion of PortGroup qmake5
--->  3 errors and 0 warnings found.
--->  Verifying Portfile for p5-crypt-openssl-rsa
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for py-cryptography
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for OpenIPMI
--->  0 errors and 0 warnings found.

Port qt5-qtbase success on xcode9.4. Log
Port qt5-qtsvg success on xcode9.4. Log
Port qt5-qtbase fail on xcode8.3. Log
Port qt5-qtsvg success on xcode8.3. Log
Port qt5-qtbase fail on xcode7.3. Log
Port qt5-qtsvg's dependencies fail on xcode7.3. Log
Port qt5-qtdeclarative's dependencies fail on xcode7.3. Log
Port qt5-qtgraphicaleffects's dependencies fail on xcode7.3. Log
Port qt5-qtimageformats's dependencies fail on xcode7.3. Log
Port qt5-qtquickcontrols2's dependencies fail on xcode7.3. Log
Port qt5-qtserialport's dependencies fail on xcode7.3. Log
Port qt5-qtsensors's dependencies fail on xcode7.3. Log
Port qt5-qtwebsockets's dependencies fail on xcode7.3. Log
Port qt5-qtwebchannel's dependencies fail on xcode7.3. Log
Port qt5-qtmacextras's dependencies fail on xcode7.3. Log
Port qt5-qtquickcontrols's dependencies fail on xcode7.3. Log
Port qt5-qtlocation's dependencies fail on xcode7.3. Log
Port qt5-qtxmlpatterns's dependencies fail on xcode7.3. Log
Port qt5-qtserialbus's dependencies fail on xcode7.3. Log
Port qt5-qtmultimedia's dependencies fail on xcode7.3. Log
Port qt5-qtcanvas3d's dependencies fail on xcode7.3. Log
Port qt5-qtnetworkauth's dependencies fail on xcode7.3. Log
Port qt5-qtremoteobjects's dependencies fail on xcode7.3. Log
Port qt5-qtscxml's dependencies fail on xcode7.3. Log
Port qt5-qtgamepad's dependencies fail on xcode7.3. Log
Port qt5-qt3d's dependencies fail on xcode7.3. Log
Port qt5-qtconnectivity's dependencies fail on xcode7.3. Log
Port qt5-qtspeech's dependencies fail on xcode7.3. Log
Port qt5-qttools's dependencies fail on xcode7.3. Log
Port qt5-qttranslations's dependencies fail on xcode7.3. Log
Port qt5-sqlite-plugin's dependencies fail on xcode7.3. Log
Port qt5's dependencies fail on xcode7.3. Log
Port qt5-qtquickcontrols2-docs's dependencies fail on xcode7.3. Log
Port qt5-qtbase-docs's dependencies fail on xcode7.3. Log
Port qt5-qtdeclarative-docs's dependencies fail on xcode7.3. Log
Port qt5-qtserialport-docs's dependencies fail on xcode7.3. Log
Port qt5-qtsensors-docs's dependencies fail on xcode7.3. Log
Port qt5-qtwebchannel-docs's dependencies fail on xcode7.3. Log
Port qt5-qtimageformats-docs's dependencies fail on xcode7.3. Log
Port qt5-qtsvg-docs's dependencies fail on xcode7.3. Log
Port qt5-qtmacextras-docs's dependencies fail on xcode7.3. Log
Port qt5-qtlocation-docs's dependencies fail on xcode7.3. Log
Port qt5-qtxmlpatterns-docs's dependencies fail on xcode7.3. Log
Port qt5-qtserialbus-docs's dependencies fail on xcode7.3. Log
Port qt5-qtmultimedia-docs's dependencies fail on xcode7.3. Log
Port qt5-qtcanvas3d-docs's dependencies fail on xcode7.3. Log
Port qt5-qtgraphicaleffects-docs's dependencies fail on xcode7.3. Log
Port qt5-qtnetworkauth-docs's dependencies fail on xcode7.3. Log
Port qt5-qtremoteobjects-docs's dependencies fail on xcode7.3. Log
Port qt5-qtscxml-docs's dependencies fail on xcode7.3. Log
Port qt5-qt3d-docs's dependencies fail on xcode7.3. Log
Port qt5-qtconnectivity-docs's dependencies fail on xcode7.3. Log
Port qt5-qtgamepad-docs's dependencies fail on xcode7.3. Log
Port qt5-qtspeech-docs's dependencies fail on xcode7.3. Log
Port qt5-qttools-docs's dependencies fail on xcode7.3. Log
Port qt5-qtquickcontrols-docs's dependencies fail on xcode7.3. Log
Port qt5-qtwebsockets-docs's dependencies fail on xcode7.3. Log
Port qt5-docs's dependencies fail on xcode7.3. Log

The build timed out.

[yan12125]

Rebased as py-cryptography is fixed independently in bd26908.

[macportsbot]

Travis Build #8387 Errored.

Lint results

--->  Verifying Portfile for qt5
Error: Line 848 repeats inclusion of PortGroup qt5
Error: Line 1583 repeats inclusion of PortGroup qmake5
Error: Line 1623 repeats inclusion of PortGroup qmake5
Error: Line 1894 repeats inclusion of PortGroup obsolete
--->  4 errors and 0 warnings found.
--->  Verifying Portfile for qt511
Error: Line 856 repeats inclusion of PortGroup qt5
Error: Line 1569 repeats inclusion of PortGroup qmake5
Error: Line 1609 repeats inclusion of PortGroup qmake5
--->  3 errors and 0 warnings found.
--->  Verifying Portfile for qt59
Error: Line 841 repeats inclusion of PortGroup qt5
Error: Line 1551 repeats inclusion of PortGroup qmake5
Error: Line 1591 repeats inclusion of PortGroup qmake5
--->  3 errors and 0 warnings found.
--->  Verifying Portfile for p5-crypt-openssl-rsa
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for OpenIPMI
--->  0 errors and 0 warnings found.

Port qt5-qtbase's dependencies fail on xcode10.3. Log
Port qt5-qtsvg success on xcode10.3. Log
Port qt5-qtdeclarative success on xcode10.3. Log
Port qt5-qtgraphicaleffects success on xcode10.3. Log
Port qt5-qtimageformats success on xcode10.3. Log
Port qt5-qtbase success on xcode9.4. Log
Port qt5-qtsvg success on xcode9.4. Log
Port qt5-qtbase fail on xcode8.3. Log
Port qt5-qtsvg success on xcode8.3. Log
Port qt5-qtbase fail on xcode7.3. Log
Port qt5-qtsvg's dependencies fail on xcode7.3. Log
Port qt5-qtdeclarative's dependencies fail on xcode7.3. Log
Port qt5-qtgraphicaleffects's dependencies fail on xcode7.3. Log
Port qt5-qtimageformats's dependencies fail on xcode7.3. Log
Port qt5-qtquickcontrols2's dependencies fail on xcode7.3. Log
Port qt5-qtserialport's dependencies fail on xcode7.3. Log
Port qt5-qtsensors's dependencies fail on xcode7.3. Log
Port qt5-qtwebsockets's dependencies fail on xcode7.3. Log
Port qt5-qtwebchannel's dependencies fail on xcode7.3. Log
Port qt5-qtmacextras's dependencies fail on xcode7.3. Log
Port qt5-qtquickcontrols's dependencies fail on xcode7.3. Log
Port qt5-qtlocation's dependencies fail on xcode7.3. Log
Port qt5-qtxmlpatterns's dependencies fail on xcode7.3. Log
Port qt5-qtserialbus's dependencies fail on xcode7.3. Log
Port qt5-qtmultimedia's dependencies fail on xcode7.3. Log
Port qt5-qtcanvas3d's dependencies fail on xcode7.3. Log
Port qt5-qtnetworkauth's dependencies fail on xcode7.3. Log
Port qt5-qtremoteobjects's dependencies fail on xcode7.3. Log
Port qt5-qtscxml's dependencies fail on xcode7.3. Log
Port qt5-qtgamepad's dependencies fail on xcode7.3. Log
Port qt5-qt3d's dependencies fail on xcode7.3. Log
Port qt5-qtconnectivity's dependencies fail on xcode7.3. Log
Port qt5-qtspeech's dependencies fail on xcode7.3. Log
Port qt5-qttools's dependencies fail on xcode7.3. Log
Port qt5-qttranslations's dependencies fail on xcode7.3. Log
Port qt5-sqlite-plugin's dependencies fail on xcode7.3. Log
Port qt5's dependencies fail on xcode7.3. Log
Port qt5-qtquickcontrols2-docs's dependencies fail on xcode7.3. Log
Port qt5-qtbase-docs's dependencies fail on xcode7.3. Log
Port qt5-qtdeclarative-docs's dependencies fail on xcode7.3. Log
Port qt5-qtserialport-docs's dependencies fail on xcode7.3. Log
Port qt5-qtsensors-docs's dependencies fail on xcode7.3. Log
Port qt5-qtwebchannel-docs's dependencies fail on xcode7.3. Log
Port qt5-qtimageformats-docs's dependencies fail on xcode7.3. Log
Port qt5-qtsvg-docs's dependencies fail on xcode7.3. Log
Port qt5-qtmacextras-docs's dependencies fail on xcode7.3. Log
Port qt5-qtlocation-docs's dependencies fail on xcode7.3. Log
Port qt5-qtxmlpatterns-docs's dependencies fail on xcode7.3. Log
Port qt5-qtserialbus-docs's dependencies fail on xcode7.3. Log
Port qt5-qtmultimedia-docs's dependencies fail on xcode7.3. Log
Port qt5-qtcanvas3d-docs's dependencies fail on xcode7.3. Log
Port qt5-qtgraphicaleffects-docs's dependencies fail on xcode7.3. Log
Port qt5-qtnetworkauth-docs's dependencies fail on xcode7.3. Log
Port qt5-qtremoteobjects-docs's dependencies fail on xcode7.3. Log
Port qt5-qtscxml-docs's dependencies fail on xcode7.3. Log
Port qt5-qt3d-docs's dependencies fail on xcode7.3. Log
Port qt5-qtconnectivity-docs's dependencies fail on xcode7.3. Log
Port qt5-qtgamepad-docs's dependencies fail on xcode7.3. Log
Port qt5-qtspeech-docs's dependencies fail on xcode7.3. Log
Port qt5-qttools-docs's dependencies fail on xcode7.3. Log
Port qt5-qtquickcontrols-docs's dependencies fail on xcode7.3. Log
Port qt5-qtwebsockets-docs's dependencies fail on xcode7.3. Log

The build timed out.

[eborisch]

LGTM (for OpenIPMI)

Thanks!

[yan12125]

Thank you for checking it out!

@MarcusCalhoun-Lopez Any comment? Due to complexity of qt5 ports, I'd like to get advices from the maintainer before commiting any non-trivial changes.

[MarcusCalhoun-Lopez]

Thank you for looking into this.

It seems that the problems with Qt Location are a bit more involved than just OpenSSL.
There are also missing dependencies on zlib and icu.
This should be easy enough to fix, but it is beyond the scope of this pull request.
Since, as you note, the dependency on OpenSSL is not really needed (it is brought in automatically by using Qt Network), it may be a better solution to add configure.args-append "QMAKE_LIBS_OPENSSL=".
Again, this may be beyond the scope of this pull request.

May I humbly suggest that Qt be treated separately than the other two ports so as not to hold up this pull request?

[MarcusCalhoun-Lopez]

Whenever dependencies are changed, doesn't that necessitate a revbump?

[mf2k]

Whenever dependencies are changed, doesn't that necessitate a revbump?

Usually, yes. There are cases when the port did not build where it is not necessary.

[yan12125]

May I humbly suggest that Qt be treated separately than the other two ports so as not to hold up this pull request?

Done - I keep qt5 changes away from this pull request. I record the original commit here: b2c64723a6aebd46d395a0a9f49acc09998e79aa as its commit message might still be useful.

Usually, yes. There are cases when the port did not build where it is not necessary.

Thanks! I bump both remaining ports.

[macportsbot]

Travis Build #8422 Failed.

Lint results

--->  Verifying Portfile for p5-crypt-openssl-rsa
--->  0 errors and 0 warnings found.
--->  Verifying Portfile for OpenIPMI
--->  0 errors and 0 warnings found.

Port p5.28-crypt-openssl-rsa success on xcode10.3. Log
Port p5-crypt-openssl-rsa success on xcode10.3. Log
Port p5.26-crypt-openssl-rsa success on xcode10.3. Log
Port OpenIPMI success on xcode10.3. Log
Port p5.28-crypt-openssl-rsa success on xcode9.4. Log
Port p5-crypt-openssl-rsa success on xcode9.4. Log
Port p5.26-crypt-openssl-rsa success on xcode9.4. Log
Port OpenIPMI success on xcode9.4. Log
Port p5.28-crypt-openssl-rsa success on xcode8.3. Log
Port p5-crypt-openssl-rsa success on xcode8.3. Log
Port p5.26-crypt-openssl-rsa success on xcode8.3. Log
Port p5.28-crypt-openssl-rsa success on xcode7.3. Log
Port p5-crypt-openssl-rsa success on xcode7.3. Log
Port p5.26-crypt-openssl-rsa success on xcode7.3. Log
Port OpenIPMI fail on xcode7.3. Log

[yan12125]

Port OpenIPMI fail on xcode7.3. Log

Well, this build fails as on the xcode7.3 builder (OS X 10.11), version 2.0.19 is used, and that old version is not compatible with OpenSSL 1.1. @eborisch I think a decision is needed (use the openssl10 port or backport patches from newer versions) before merging this PR.

[eborisch]

Ugh. I'll try to talk a look at that when I have a chance. I doubt that the number of users on old systems using OpenIPMI is greater than 0 worldwide, so I may just have it error out.

[yan12125]

Got it! Then let's merge this first to benefit users on modern systems.