Merge upstream changes from https://github.com/ajrcarey/pdfium-render #1
+59,906
−7,603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdfium_6611` and `pdfium_future` features
Fix missing feature gate for `FPDFText_GetTextObject` on dynamic bindings
- Add tests covering most of the PdfBookmarks and PdfBookmark implementation, and all of the PdfBookmarksIterator implementation. - Fix iter_siblings() when the parent node is known, iter_direct_children(), and iter_all_descendents() to not include node on which those functions were called. - These changes made it so that every PdfBookmarksIterator::new() call had include_siblings==true and include_direct_children==include_all_descendants, so elide include_siblings, and consolidate include_direct_children and include_all_descendants into just include_descendants. - Simplify the PdfBookmarksIterator implementation, and make it yield bookmarks in a more natural order; clarify the documentation regarding the order the bookmarks are returned. - Fix children_len() to behave as documented when the underlying FPDFBookmark_GetCount() returns a negative number.
Progressing #164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.