Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically test examples for new PRs #152

Closed
3 tasks done
RuaridhMacd opened this issue Jul 10, 2023 · 4 comments
Closed
3 tasks done

Automatically test examples for new PRs #152

RuaridhMacd opened this issue Jul 10, 2023 · 4 comments
Assignees

Comments

@RuaridhMacd
Copy link
Collaborator

RuaridhMacd commented Jul 10, 2023

@Betristor

  • Create a workflow in GitHub Actions to test the three SmallNewEngland cases using HiGHs after each PR
  • Base off of genx_as_submodule
  • Use Documentation.yml as a template
@Betristor
Copy link
Collaborator

@RuaridhMacd I write a runtest.jl using Test pkg to automatically run test scripts for us. But i can only manage to have it work locally after you activate local environment and type test in pkg management mode. To have this test work on github actions, I believe I need to figure out how to install highs solver on the machine that github will use when the action is triggered.
BTW, I checked GenX's runtests script, they just used some simple operations like addition which is invalid in testing. You could find new changes made to your branch on testDolphyn branch.
Anna's ThreeZones_Liquid case still fails in my situation. So I commented test script for her case. If it's functionable, test could be added at any time.
Sorry that I decided not to use Documentation.yml as example, I've found a test script dedicated for julia test called Run Julia package test created by julia-actions. The next step is to figure out how to install highs solver on the test environment.

@RuaridhMacd
Copy link
Collaborator Author

RuaridhMacd commented Jul 31, 2023

  • @RuaridhMacd Take a look at the Gtihub Actions log files to diagnose error
  • @Betristor Work out how to download and install HiGHs to a Github Actions machine
  • @Betristor Ask Greg Schivley on the Princeton about installing HiGHs

@Betristor Betristor linked a pull request Aug 16, 2023 that will close this issue
@Betristor
Copy link
Collaborator

Betristor commented Aug 16, 2023

@RuaridhMacd I believed that PR #156 has fulfilled things we required here. And I found that highs binary is not needed to perform the tests, at least in ubuntu machines. I'd like to close this issue with PR #156 merged.

@RuaridhMacd
Copy link
Collaborator Author

Resolved by #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants