Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto test using github actions #156

Closed
wants to merge 7 commits into from
Closed

Auto test using github actions #156

wants to merge 7 commits into from

Conversation

Betristor
Copy link
Collaborator

  1. Change solver from gurobi to highs
  2. Configure highs options to be compatiable with HiGHs.jl
  3. Compare results with example we provided
  4. Add github action workflow

@Betristor Betristor requested a review from RuaridhMacd August 9, 2023 15:17
@Betristor Betristor self-assigned this Aug 9, 2023
checkout submodules.
@Betristor
Copy link
Collaborator Author

@RuaridhMacd Automatic test using github actions on one-zone case is done, other cases could be appended after one zone test script. I cached julia project for reusage using julia-actions/cache and tried to compare results with example folders. Now the only problem is how to notify users when summary.txt is created.

@RuaridhMacd
Copy link
Collaborator

@Betristor This is great! I hadn't realized installing HiGHS.jl also installs the HiGHS binary. That makes it much easier.

Let me know if you'd like to discuss how to compare results, but I think a simple table which compares the "Total" columns of costs.csv and hsc_costs.csv would be a good start.

Copy link
Collaborator

@RuaridhMacd RuaridhMacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the SmallNewEngland examples work for me locally. The NorthSea example also works but is much slower with HiGHS than with Gurobi.

I'd recommend that we also run ThreeZones_Liquid, as that tests some of the features missing from the OneZone case.

1. Add threezones, liquid and northsea case test
2. Add keywords ['#skip', 'CompatHelper'] to allow test bypassing to save unnecessary github action
Pair condition judgment. #skip.
@Betristor
Copy link
Collaborator Author

Betristor commented Aug 15, 2023

@Betristor This is great! I hadn't realized installing HiGHS.jl also installs the HiGHS binary. That makes it much easier.

Let me know if you'd like to discuss how to compare results, but I think a simple table which compares the "Total" columns of costs.csv and hsc_costs.csv would be a good start.

@RuaridhMacd I found there is no need to install highs binary on github ubuntu machine to perform the tests. And I added other example case to be tested.
Considering how to check whether results are in match with previous version, your script compare_results is a good starting point.
Besides I added conditions to allow test bypassing since there exist some situations when we don't want the test to be triggered. When specified keywords are included in the commit message, then the test could be skipped.

@Betristor Betristor requested a review from RuaridhMacd August 16, 2023 12:21
@Betristor Betristor linked an issue Aug 16, 2023 that may be closed by this pull request
3 tasks
@Betristor Betristor closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically test examples for new PRs
2 participants