-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in writing HSC costs #50
Comments
Issue can be fixed by setting H2_STOR = 2 in the HSC_generation.csv file. Delete H2_STOR = 1 and replace it with 2. |
HI, @Junwenlaw are you testing the whole module of GenX and HSC for stability? |
I am not familiar with the truck module, so I turned off that module to run my work. Apart from that it is working fine I think. I am not doing any tests for GenX and HSC and I just happen to find out the HSC error for writing the cost when running case studies. |
That's very nice of you to check for the stability and functionality of the code. The truck module seems fine when I'm checking the output, but turning it on will bring extra burden on computation. |
H2_STOR=1, where charging and discharging capacities are symmetric should be deleted since it physically does not make sense (no reason for H2 compression and H2 release from the gas tank to be equally sized). H2_STOR=2 should be the only way to model storage. |
@anna-nadia and @Junwenlaw I just submitted a pull request that redid the H2 storage module to make the above change. Please review so that we can merge into the main branch |
Resolved in PR 55: #55 |
There seemed to be an error with writing the HSC cost using 3 zone example system, and it will specify that "eTotalCFixH2Charge not found". This is strange as the storage module is running well with outputs but somehow not the cost.
The text was updated successfully, but these errors were encountered: