Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in writing HSC costs #50

Closed
Junwenlaw opened this issue Sep 7, 2022 · 8 comments
Closed

Error in writing HSC costs #50

Junwenlaw opened this issue Sep 7, 2022 · 8 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers wip

Comments

@Junwenlaw
Copy link
Collaborator

There seemed to be an error with writing the HSC cost using 3 zone example system, and it will specify that "eTotalCFixH2Charge not found". This is strange as the storage module is running well with outputs but somehow not the cost.

@Junwenlaw
Copy link
Collaborator Author

Issue can be fixed by setting H2_STOR = 2 in the HSC_generation.csv file. Delete H2_STOR = 1 and replace it with 2.

@Betristor
Copy link
Collaborator

HI, @Junwenlaw are you testing the whole module of GenX and HSC for stability?

@Betristor Betristor added bug Something isn't working good first issue Good for newcomers wip labels Sep 9, 2022
@Junwenlaw
Copy link
Collaborator Author

Junwenlaw commented Sep 9, 2022

I am not familiar with the truck module, so I turned off that module to run my work. Apart from that it is working fine I think. I am not doing any tests for GenX and HSC and I just happen to find out the HSC error for writing the cost when running case studies.

@Betristor
Copy link
Collaborator

That's very nice of you to check for the stability and functionality of the code. The truck module seems fine when I'm checking the output, but turning it on will bring extra burden on computation.

@anna-nadia
Copy link
Collaborator

The error is a result of using H2_STOR = 1, because of the new conditions in the h2_storage.jl file. The write_costs file should be updated so that there is no error when H2_STOR = 1.
Pasted Graphic

@dharik13
Copy link
Collaborator

H2_STOR=1, where charging and discharging capacities are symmetric should be deleted since it physically does not make sense (no reason for H2 compression and H2 release from the gas tank to be equally sized). H2_STOR=2 should be the only way to model storage.

@dharik13
Copy link
Collaborator

@anna-nadia and @Junwenlaw I just submitted a pull request that redid the H2 storage module to make the above change. Please review so that we can merge into the main branch

@dharik13
Copy link
Collaborator

Resolved in PR 55: #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers wip
Projects
None yet
Development

No branches or pull requests

4 participants