Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2-Storage-module-edits #55

Merged
merged 10 commits into from
Sep 14, 2022
Merged

H2-Storage-module-edits #55

merged 10 commits into from
Sep 14, 2022

Conversation

dharik13
Copy link
Collaborator

@dharik13 dharik13 commented Sep 12, 2022

Redid H2 Storage module
3cf032d
Modified the H2 storage module to eliminate separation between symmetric and asymmetric type of storage. All H2 storage systems will involve charging and energy capacity cost and limits. In future, if and when we model other types of H2 storage (liquified or LOHC) where discharging capacity is constrained , then we need to create another storage type (e.g. H2_STOR=2) to account for discharging capacity limits and costs.

Details of changes:

  • Renamed H2 STOR_SYMMETRIC (H2_STOR=1) to H2_STOR_ABOVEGROUND_GAS corresponding to modeling gaseous H2 storage in compressed tanks.
  • Eliminated H2_STOR_ASYMMETRIC set corresponding to H2_STOR=2
    -Applied constraint limiting rate of charging to installed capacity for all H2 storage resources (H2_STOR_ALL)
  • Change year of DOLPHYN license copyright across the various files
  • Deleted mention of Modeling to generate alternatives across the various files and documentation

dharik13 added 6 commits June 13, 2022 18:28
- to work with Gurobi.jl v 0.10.0 or higher that is required to use Gurobi 9.5 or higher
Modified the H2 storage module to eliminate separation between symmetric and asymmetric type of storage. All H2 storage systems will involve charging and energy capacity cost and limits. In future, if and when we model other types of H2 storage (liquified or LOHC)  where discharging capacity is constrained , then we need to create another storage type (e.g. H2_STOR=2) to account for discharging capacity limits and costs.

Details of changes:
- Renamed H2 STOR_SYMMETRIC (H2_STOR=1) to H2_STOR_ABOVEGROUND_GAS corresponding to modeling gaseous H2 storage in compressed tanks.
- Eliminated H2_STOR_ASYMMETRIC set corresponding to H2_STOR=2
-Applied constraint limiting rate of charging to installed capacity for all H2 storage resources (H2_STOR_ALL)
- Change year of DOLPHYN license copyright across the various files
- Deleted mention of Modeling to generate alternatives across the various files and documentation
- Updated README.md
@dharik13 dharik13 closed this Sep 12, 2022
@dharik13 dharik13 reopened this Sep 12, 2022
@dharik13 dharik13 closed this Sep 12, 2022
@dharik13 dharik13 reopened this Sep 12, 2022
@dharik13 dharik13 changed the title Dharik edits H2-Storage-module-edits Sep 12, 2022
Copy link
Collaborator

@Junwenlaw Junwenlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load_h2_gen.jl line 54 has an issue with inputs_gen["H2_STOR_ALL"] = inputs_gen["H2_STOR_GAS"] and error is produced: key "H2_STOR_GAS" not found. Propose changing line to "inputs_gen["H2_STOR_ALL"] = h2_gen_in[h2_gen_in.H2_STOR.>=1,:R_ID]" to include both storage type 1 and 2 for all storage units.

- Updated README.md file on the main DOLPHYN page
@dharik13 dharik13 requested a review from Junwenlaw September 13, 2022 01:20
Copy link
Collaborator

@Junwenlaw Junwenlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend to replace all the settings file of ThreeZones example with setting files from 2020_No_EC. It seems the settings of the Small New England example is not updated and causes error when running. Problem is solved after updating the setting files with those from the other example system.

Small New England Example settings and run file updates.
@dharik13 dharik13 requested a review from Junwenlaw September 13, 2022 02:25
Junwenlaw
Junwenlaw previously approved these changes Sep 13, 2022
Copy link
Collaborator

@Junwenlaw Junwenlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be running well.

@shakesy94
Copy link
Collaborator

Left a variety of comments in terms of importance. Comments should be addressed or added to issues to be addressed in a different PR.

- Typos related to set "H2_STOR_LONG_DURATION" in h2_long_duration_storage.jl
- modified if condition when truck related input files are read. Setup["ModelH2Trucks"] now controls whether trucks are modeled or not.
@dharik13
Copy link
Collaborator Author

@shakesy94 please re-review as I have responded to all of your comments. If everything looks good, please approve so that it can be merged to main.

@shakesy94
Copy link
Collaborator

The changes look good to me. One last thing, did you get a chance to look at my response here? #57 (comment)

- check if H2_STOR_DURATION is non-empty before enforcing a constraint over that set.
@dharik13
Copy link
Collaborator Author

@shakesy94 - just updated to respond to #57 (comment)

This was referenced Sep 14, 2022
Copy link
Collaborator

@shakesy94 shakesy94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dharik13 dharik13 requested a review from Junwenlaw September 14, 2022 21:34
@dharik13 dharik13 merged commit f710636 into main Sep 14, 2022
@Junwenlaw Junwenlaw deleted the dharik_edits branch July 11, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants