-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
H2-Storage-module-edits #55
Conversation
- to work with Gurobi.jl v 0.10.0 or higher that is required to use Gurobi 9.5 or higher
This reverts commit e59498d.
Modified the H2 storage module to eliminate separation between symmetric and asymmetric type of storage. All H2 storage systems will involve charging and energy capacity cost and limits. In future, if and when we model other types of H2 storage (liquified or LOHC) where discharging capacity is constrained , then we need to create another storage type (e.g. H2_STOR=2) to account for discharging capacity limits and costs. Details of changes: - Renamed H2 STOR_SYMMETRIC (H2_STOR=1) to H2_STOR_ABOVEGROUND_GAS corresponding to modeling gaseous H2 storage in compressed tanks. - Eliminated H2_STOR_ASYMMETRIC set corresponding to H2_STOR=2 -Applied constraint limiting rate of charging to installed capacity for all H2 storage resources (H2_STOR_ALL) - Change year of DOLPHYN license copyright across the various files - Deleted mention of Modeling to generate alternatives across the various files and documentation - Updated README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
load_h2_gen.jl line 54 has an issue with inputs_gen["H2_STOR_ALL"] = inputs_gen["H2_STOR_GAS"] and error is produced: key "H2_STOR_GAS" not found. Propose changing line to "inputs_gen["H2_STOR_ALL"] = h2_gen_in[h2_gen_in.H2_STOR.>=1,:R_ID]" to include both storage type 1 and 2 for all storage units.
- Updated README.md file on the main DOLPHYN page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend to replace all the settings file of ThreeZones example with setting files from 2020_No_EC. It seems the settings of the Small New England example is not updated and causes error when running. Problem is solved after updating the setting files with those from the other example system.
Small New England Example settings and run file updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be running well.
Left a variety of comments in terms of importance. Comments should be addressed or added to issues to be addressed in a different PR. |
- Typos related to set "H2_STOR_LONG_DURATION" in h2_long_duration_storage.jl - modified if condition when truck related input files are read. Setup["ModelH2Trucks"] now controls whether trucks are modeled or not.
@shakesy94 please re-review as I have responded to all of your comments. If everything looks good, please approve so that it can be merged to main. |
The changes look good to me. One last thing, did you get a chance to look at my response here? #57 (comment) |
- check if H2_STOR_DURATION is non-empty before enforcing a constraint over that set.
@shakesy94 - just updated to respond to #57 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Redid H2 Storage module
3cf032d
Modified the H2 storage module to eliminate separation between symmetric and asymmetric type of storage. All H2 storage systems will involve charging and energy capacity cost and limits. In future, if and when we model other types of H2 storage (liquified or LOHC) where discharging capacity is constrained , then we need to create another storage type (e.g. H2_STOR=2) to account for discharging capacity limits and costs.
Details of changes:
-Applied constraint limiting rate of charging to installed capacity for all H2 storage resources (H2_STOR_ALL)