H2 Storage incorrect set names

[shakesy94]

https://github.com/MacroEnergyProject/DOLPHYN-dev/blob/1a8c3bf3dfd92c82aca1a37546f9e66d2726dbd8/src/HSC/model/storage/h2_storage_all.jl#L142

this constraints indexes over H2_STOR_SHORT_DURATION, this should be H2_STOR_LONG_DURATION instead. Moreover, the H2_STOR_LONG_DURATION is not defined. Instead the following line at the beginning of the function should be added H2_STOR_LONG_DURATION = inputs["H2_STOR_LONG_DURATION"]

Additionally, incorrect set names in https://github.com/MacroEnergyProject/DOLPHYN-dev/blob/1a8c3bf3dfd92c82aca1a37546f9e66d2726dbd8/src/HSC/model/storage/h2_long_duration_storage.jl#L98 and https://github.com/MacroEnergyProject/DOLPHYN-dev/blob/1a8c3bf3dfd92c82aca1a37546f9e66d2726dbd8/src/HSC/model/storage/h2_long_duration_storage.jl#L102

Should be H2_STOR_LONG_DURATION instead of STOR_LONG_DURATION

[shakesy94]

@dharik13 could be add to the PR that you already have open. Requires 2 line changes. Otherwise, I can pull a PR and merge it when you merge yours.

[dharik13]

@shakesy94 thanks for catching these errors. One note, the constraint H2SoCBalStart in h2_storage_all.jl should index over all resources belonging to H2_STOR_SHORT_DURATION (and not H2_STOR_LONG_DURATION as you suggested). The if conditions checks whether the representative weeks are being modeled and if the H2_STOR_LONG_DURATION is non-empty. If yes, then we apply the constraints only to those technologies part of H2_STOR_SHORT_DURATION, else we apply them to set H2_STOR_ALL. I made the edit to H2-storage-module-edits and will push it to the PR

[shakesy94]

Ohh okay, in this case, should we also check if H2_STOR_SHORT_DURATION is not empty in the if statement? If operation wrapping is on and long duration storage is not empty and short duration storage is empty, the statement will execute and return an error.

[dharik13]

@shakesy94 Good point on checking for H2_STOR_SHORT_DURATION. Resolved in this pull request 55: #55

[dharik13]

Resolved in TDR 55: #55