Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in how compare_results.jl prints missing files #107

Merged
merged 4 commits into from
Nov 28, 2022

Conversation

RuaridhMacd
Copy link
Collaborator

When comparing two results folders, files which were missing in one of the folders were being printed in one line, instead of as a list. This fixes that.

@RuaridhMacd RuaridhMacd added the bug Something isn't working label Nov 20, 2022
@RuaridhMacd RuaridhMacd self-assigned this Nov 20, 2022
@RuaridhMacd
Copy link
Collaborator Author

I've accidentally also included the Julia 1.8 fix here as well.

The changes relevant to this PR are in compare_results.jl

Copy link
Collaborator

@Betristor Betristor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gonna to be very helpful, but what does the output file look like.

@Betristor Betristor added enhancement New feature or request DOLPHYN UX DOLPHYN User Experience labels Nov 21, 2022
@RuaridhMacd
Copy link
Collaborator Author

I've attached an example output below. In comparing two results directories, the comparison reports:

  1. Which files / subdirectories are missing from one directory or another.
  2. Of the files which are in both, which files match or are mismatched.
  3. It then repeats this recursively for any subdirectories.

summary.txt

@RuaridhMacd RuaridhMacd merged commit efa201c into main Nov 28, 2022
@RuaridhMacd RuaridhMacd deleted the Fix-compare_results-printing-bug branch November 28, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DOLPHYN UX DOLPHYN User Experience enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants