Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed tdr bugs for constant power and h2 loads #111

Merged
merged 2 commits into from
Dec 1, 2022
Merged

fixed tdr bugs for constant power and h2 loads #111

merged 2 commits into from
Dec 1, 2022

Conversation

shakesy94
Copy link
Collaborator

@shakesy94 shakesy94 commented Dec 1, 2022 •
edited
Loading

PR To fix this issue #58

@shakesy94 shakesy94 linked an issue Dec 1, 2022 that may be closed by this pull request
TDR not working in constant power and H2 load #58
Closed
@shakesy94
Copy link
Collaborator Author

The fixes are complete. This is ready for review.

Junwenlaw
Junwenlaw approved these changes Dec 1, 2022
View reviewed changes
Copy link
Collaborator

@Junwenlaw Junwenlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well!

@Junwenlaw Junwenlaw merged commit 676bb83 into main Dec 1, 2022
@RuaridhMacd RuaridhMacd deleted the constant_h2_power_tdr_fix branch January 29, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junwenlaw Junwenlaw Junwenlaw approved these changes

@dharik13 dharik13 Awaiting requested review from dharik13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TDR not working in constant power and H2 load
2 participants
@shakesy94 @Junwenlaw