-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track power balance using expressions #117
Conversation
Revise the PR to populate eAdditionalDemandbyZone expression with power consumption by H2 supply chain. |
@RuaridhMacd |
|
@RuaridhMacd There exist some codes with index sequence of zone and time (z,t) in genx we used in main branch such as |
@Betristor This looks good. I think it's fine to leave the other existing (z,t) cases for now, to avoid causing issues. Are you ready for me to review and merge this? |
@RuaridhMacd These expressions won't affect any codes in establishing the model but just track some numbers we want to know. As a start, I hope with the model scope expanding, these expressions could help record any detailed while small terms as a whole and save the trouble in writing output part. I added a term in write_h2_balance.jl named transmission. Now it's ready to go. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes worked for me on the three example systems and the additional expressions were written correctly.
@Betristor , merge this if you're happy to proceed.
@RuaridhMacd I merged the PR. |
In power sector, power balance plays the most important role in establishing the model and its composition will be more and more complicated if we keep adding more terms, which will definitely cause problem when writing power balance in results.
P.S. Hydrogen sector is not handled so additional demand is not processed. By the way expression eH2NetpowerConsumptionByAll could be used as part of additional demand but term additional demand could be extended if more sectors are to be added.