Fixed bugs in write_outputs and TDR for HSC #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have updated the data file for the three zones SmallNewEngland model to comply with the GenX submodule's version.
I have also made changes to the write_outputs.jl to make sure the folder Results_HSC is correctly saved in Results_n for n=1,2,3,4...
The main bug fix is on TDR for HSC. In the previous version, HSC was not using the representative periods computed by the GenX submodule. Hence, HSC might have been formulated on different representative periods than GenX. I have added a function to inherit the representative periods from GenX. Note: Representative periods are now computed based on electricity sectors timeseries and inherited by HSC.