Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated start shut time constraints #16

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Updated start shut time constraints #16

merged 2 commits into from
Apr 21, 2022

Conversation

Junwenlaw
Copy link
Collaborator

To match GenX constraint formulation in Thermal Commit file.

@Junwenlaw
Updated start shut time constraints
64fc05e 
To match GenX constraint formulation in Thermal Commit file.
dharik13
dharik13 requested changes Apr 21, 2022
View reviewed changes
Copy link
Collaborator

@dharik13 dharik13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the docstring comments that add documentation for the function hours before as well in your code and then resubmit a PR? I can approve it then.

I am referring to stuff that is @doc raw """ ...

@dharik13 dharik13 merged commit 9abf651 into main Apr 21, 2022
@Junwenlaw Junwenlaw deleted the Edit_to_main branch July 11, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharik13 dharik13 dharik13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Junwenlaw @dharik13