Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue and PR templates #179

Merged
merged 9 commits into from
Oct 3, 2023
Merged

Add issue and PR templates #179

merged 9 commits into from
Oct 3, 2023

Conversation

bennettm
Copy link
Collaborator

Hi Dharik,

I have modified the templates per our conversation at today's meeting. Will you be able to review and approve so I can merge the changes into main?

thanks,

Mary

dharik13
dharik13 previously approved these changes Sep 25, 2023
@dharik13
Copy link
Collaborator

@bennettm I have reviewed, but it seems there is failure in documentation building.

@bennettm
Copy link
Collaborator Author

@bennettm I have reviewed, but it seems there is failure in documentation building.

Yes, it happens to other branches as well. It seems to come from GenX. I have contacted Luca and see what he will reply.

@RuaridhMacd
Copy link
Collaborator

@bennettm Hi Mary, I just made some small changes to the forms. Sorry for cluttering the commit history - I could only preview after commits. Let me know if there's anything missing, otherwise I'll push it this morning.

@bennettm
Copy link
Collaborator Author

bennettm commented Oct 3, 2023

@bennettm Hi Mary, I just made some small changes to the forms. Sorry for cluttering the commit history - I could only preview after commits. Let me know if there's anything missing, otherwise I'll push it this morning.

@RuaridhMacd, looks good. As to the number of commits, do a squash and merge then.

@RuaridhMacd RuaridhMacd merged commit 668a97a into main Oct 3, 2023
@RuaridhMacd RuaridhMacd deleted the issue_pr_tmplts branch October 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants