Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.2.1 Cleanup packages and separate solver #198

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

RuaridhMacd
Copy link
Collaborator

Description

This PR includes the following:

  • Removed unused packages
  • Separated Gurobi and CPLEX from Dolphyn. HiGHS is now the default and the others must be added separately in the run file and global_model_settings.yml. This is not a breaking change in how the code runs, but Gurobi, CPLEX, etc. must be added separately.
  • Added HiGHS settings to NorthSea example.
  • Fixed incorrect settings in HIGHS default config.
  • Created run_tools to simplify run files
  • Updated documentation for the examples
  • Updated the README with instructions for how to install DOLPHYN

Fixes issue #

No associated issue

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Example_Systems/SmallNewEngland/OneZone
  • Example_Systems/SmallNewEngland/ThreeZones

Test Configuration:

  • OS: Mac Sonoma
  • Solver: Gurobi and HiGHS
  • Julia version: 1.6.7 -> 1.9.3
  • Solver version: Gurobi 10.0, HiGHS 1.6.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run tests with my code to avoid compatibility issues
  • Any dependent changes have been merged and published in downstream modules

- Removed unused packages
- Removed Gurobi and CPLEX from Dolphyn. HiGHS is now the default and the others must be added separately in the run file.
- Added HiGHS settings to NorthSea example.
- Fixed incorrect settings in HIGHS default config.
- Created run_tools to simplify run files
@RuaridhMacd RuaridhMacd merged commit ef69266 into main Nov 14, 2023
1 check passed
@RuaridhMacd RuaridhMacd deleted the v0_2_1-cleanup-packages branch November 14, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant