Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synthetic fuels merge #205

Merged
merged 10 commits into from
Dec 14, 2023
Merged

synthetic fuels merge #205

merged 10 commits into from
Dec 14, 2023

Conversation

shakesy94
Copy link
Collaborator

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes issue #

Please tag any associated issues here using the format Fixes #<issue number>. If there is no associated issue, please type No associated issue.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Example_Systems/SmallNewEngland/OneZone
  • Example_Systems/SmallNewEngland/ThreeZones

Test Configuration:

  • OS:
  • Solver:
  • Julia version:
  • Solver version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run tests with my code to avoid compatibility issues
  • Any dependent changes have been merged and published in downstream modules

@shakesy94 shakesy94 changed the title intial push synthetic fuels merge Dec 7, 2023
@shakesy94 shakesy94 marked this pull request as draft December 7, 2023 03:23
- Updated run file
- updated liquid fuel settigns file
- updated default settings
- Updated Generate Model
- Fixed typos in HSC output files
- changed naming conventions in liquid fuel demand
- added choose lf output dir
- updated emissions file
@shakesy94 shakesy94 changed the base branch from Liquid_Fuels_Merge to develop December 9, 2023 22:03
@shakesy94 shakesy94 changed the base branch from develop to Liquid_Fuels_Merge December 10, 2023 00:14
@shakesy94 shakesy94 marked this pull request as ready for review December 10, 2023 00:15
@shakesy94 shakesy94 changed the base branch from Liquid_Fuels_Merge to develop December 10, 2023 00:16
@shakesy94 shakesy94 changed the base branch from develop to Liquid_Fuels_Merge December 14, 2023 21:01
@shakesy94 shakesy94 changed the base branch from Liquid_Fuels_Merge to develop December 14, 2023 21:01
@shakesy94 shakesy94 changed the base branch from develop to Liquid_Fuels_Merge December 14, 2023 21:04
@shakesy94 shakesy94 merged commit 18c6433 into Liquid_Fuels_Merge Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants