Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes examples #23

Merged
merged 4 commits into from
May 18, 2022
Merged

Bug fixes examples #23

merged 4 commits into from
May 18, 2022

Conversation

shakesy94
Copy link
Collaborator

Fixed multiple bugs (including TDR). Added 2 examples, and adjusted run file for New England example.

shakesy94 added 2 commits May 2, 2022 22:58
Fixed some minor bugs that I found will running EU models.
Added combined hydrogen + power model, and power only model. All 3 examples now have a fixed run file. Doesn't overwrite TDR_Results folder for power only models anymore.
@shakesy94 shakesy94 requested a review from dharik13 May 3, 2022 05:15
Copy link
Collaborator

@dharik13 dharik13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Youssef, please remove figures and results files from your commit and resubmit again. I can approve it then.

Deleted results and examples files from example models
@shakesy94 shakesy94 requested a review from dharik13 May 11, 2022 16:02
Copy link
Collaborator

@dharik13 dharik13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this file for the new examples you provided: Example_Systems/2030_CombEC_DETrans/README.md

Added relevant details to readme filed. Fixed issues w Norway-Sweden transmission line.
@shakesy94
Copy link
Collaborator Author

Fixed network data issues and updated readme files. @dharik13

@dharik13 dharik13 merged commit fdb495a into main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants