Main documentation implementation #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I deleted src/HSC/model/storage/h2_storage_investment.jl because it was split into two files src/HSC/model/storage/h2_storage_investment_energy.jl and src/HSC/model/storage/h2_storage_investment_charge.jl. |
|
I have taken a look at the documentations, and they mainly seem fine, but one feedback is that for storage charge, it might be better to label the documentations as hydrogen instead of power, and cost could be represented by pi rather than c to be consistent with the GenX documentation. |
|
Ok, I wll add these on. |
|
Simultaneously, I extended version checking code to version 1.8 of julia in the commit to solve issue #20. |
dharik13
approved these changes
Aug 15, 2022
|
I will delete this branch after it is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make.jl