Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to output file #64

Merged
merged 5 commits into from
Oct 2, 2022
Merged

Changes to output file #64

merged 5 commits into from
Oct 2, 2022

Conversation

Junwenlaw
Copy link
Collaborator

Now write HSC emissions regardless of type of cap

Now write HSC emissions regardless of type of cap
@Junwenlaw Junwenlaw requested review from Betristor and dharik13 and removed request for Betristor September 27, 2022 20:14
@Betristor
Copy link
Collaborator

@Junwenlaw Hi, Junwen, I changed a file linking in DOLPHYN.jl to bypass the documentation check. A upstream error in main branch now will affect all branches created from main branch and this error will be fixed in PR #46.

@Betristor
Copy link
Collaborator

I tested an example system, I think everything works fine from the results.

@Betristor Betristor added enhancement New feature or request good first issue Good for newcomers labels Sep 28, 2022
Betristor
Betristor previously approved these changes Sep 28, 2022
@Betristor Betristor linked an issue Sep 28, 2022 that may be closed by this pull request
Changed STOR = 1
Betristor
Betristor previously approved these changes Sep 29, 2022
Fixed bug in power balance storage column number output, added HSC power consumption into power balance. Fixed bugs in HSC code to account properly for power consumption variable.
Copy link
Collaborator Author

@Junwenlaw Junwenlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes done and new updates to resolve error in power balance storage column output and also add HSC consumption column in power balance.

Betristor
Betristor previously approved these changes Sep 29, 2022
Fixed generation column to include THERM >=1 instead of THERM ==1.
H2-G2P is already scaled in HSC code so no need to multiply by scaling factor in power balance output.
@Junwenlaw Junwenlaw requested review from shakesy94 and removed request for dharik13 September 29, 2022 14:41
@Junwenlaw Junwenlaw removed the request for review from shakesy94 September 29, 2022 20:06
Copy link
Collaborator

@anna-nadia anna-nadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would just add that the "Storage_Discharge" column values are currently negative, which I guess is related to the problem fixed here. So I would check that the outputs now have positive discharge and negative charge values (previously zero). And also check that the new HSC_consumption column will show up negative. I am assuming that the trucking consumption is for battery-electric trucks?

@dharik13
Copy link
Collaborator

@Junwenlaw can you please address Anna's comment so that we can push this to main.

@Junwenlaw
Copy link
Collaborator Author

Looks good to me. I would just add that the "Storage_Discharge" column values are currently negative, which I guess is related to the problem fixed here. So I would check that the outputs now have positive discharge and negative charge values (previously zero). And also check that the new HSC_consumption column will show up negative. I am assuming that the trucking consumption is for battery-electric trucks?

Currently from my test cases they are correct. The HSC consumption comes from power consumed to produce hydrogen and operating the pipeline.

@Junwenlaw Junwenlaw merged commit 929ec0f into main Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposed changes to write_HSC_outputs.jl
4 participants