-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to output file #64
Conversation
Now write HSC emissions regardless of type of cap
@Junwenlaw Hi, Junwen, I changed a file linking in DOLPHYN.jl to bypass the documentation check. A upstream error in main branch now will affect all branches created from main branch and this error will be fixed in PR #46. |
I tested an example system, I think everything works fine from the results. |
Changed STOR = 1
Fixed bug in power balance storage column number output, added HSC power consumption into power balance. Fixed bugs in HSC code to account properly for power consumption variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes done and new updates to resolve error in power balance storage column output and also add HSC consumption column in power balance.
Fixed generation column to include THERM >=1 instead of THERM ==1. H2-G2P is already scaled in HSC code so no need to multiply by scaling factor in power balance output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I would just add that the "Storage_Discharge" column values are currently negative, which I guess is related to the problem fixed here. So I would check that the outputs now have positive discharge and negative charge values (previously zero). And also check that the new HSC_consumption column will show up negative. I am assuming that the trucking consumption is for battery-electric trucks?
@Junwenlaw can you please address Anna's comment so that we can push this to main. |
Currently from my test cases they are correct. The HSC consumption comes from power consumed to produce hydrogen and operating the pipeline. |
Now write HSC emissions regardless of type of cap