db: refactor the crate #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How should we proceed with #28 and this one? @Trantorian1 |
antiyro
approved these changes
Mar 30, 2024
Trantorian1
reviewed
Mar 30, 2024
Trantorian1
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Resolves: #NA
What is the new behavior?
Got rid of kvdb and kvdb-rocksdb.
Does this introduce a breaking change?
N/A
Other information
All locks are removed, accesses to bonsai storages are mediated through the BonsaiStorageAccess wrapper, which you can use to do read accesses, or get a owned BonsaiStorage to make writes.
PersistentBonsaiDatabase is now implemented properly
All Backend db accesses are now using rocksdb directly