chore(ci): minor fixes to improve CI workflow #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbcaron
force-pushed
the
chore/ci-minor-fixes
branch
2 times, most recently
from
43a7758 to
4c2246c
Compare
jbcaron
force-pushed
the
chore/ci-minor-fixes
branch
from
4c2246c to
8e71e95
Compare
jbcaron
force-pushed
the
chore/ci-minor-fixes
branch
5 times, most recently
from
146fa20 to
688bb33
Compare
Trantorian1
approved these changes
Jan 13, 2025
| echo "✅ All tests passed successfully!" | ||
| else | ||
| echo "❌ Some tests failed." | ||
| exit 1 |
There was a problem hiding this comment.
Why exit 1 for e2e tests but not coverage?
There was a problem hiding this comment.
It depends on whether we still want the coverage report despite the test failures
jbcaron
force-pushed
the
chore/ci-minor-fixes
branch
4 times, most recently
from
7164a4c to
a291cb5
Compare
jbcaron
force-pushed
the
chore/ci-minor-fixes
branch
from
468bb14 to
c78c98b
Compare
This reverts commit 97f815e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
Resolves: #NA
What is the new behavior?
Does this introduce a breaking change?
No
Other information