Orchestrator CI Merge #472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Is this pr here to test the CI? Wondering why we don't integrate this into #471 directly |
Trantorian1
added
the
infrastructure
Foo (test) Simplify workflow reqs
notlesh
force-pushed
the
notlesh/orchestrator-ci-merge
branch
from
cab7491 to
66a3602
Compare
Yes, it's to test CI without making a mess in the original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges in the
madara-orchestratorgithub workflows. Part of #471.TODO:
Conditionally running CI
Ideally, we can reliably detect when something changed that requires certain parts of CI to run. Orchestrator does not need to run if only Madara changed and vise-versa.
That's the theory, anyway. It could be argued that there is value in running e.g. Orchestrator when Madara changes, as changes in Madara could cause breakage in Orchestrator. The inverse is probably not true. This is a lot of CI workload, however, so a compromise might be to only do this when merging into
mainor when doing a release.