Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : Trace_transaction RPC call implementation #8

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

Tbelleng
Copy link
Contributor

@Tbelleng Tbelleng commented Mar 6, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature ✅

What is the new behavior?

Add trace_transaction RPC call and modify trace_block_transactions ✅
In this new implementation, we are going to separate transactions from a block into 2 vectors,
the first one contains transactions that we dont want to trace but we still need to re-execute them in order to
get the correct state update.

The second vector contains transactions that we want to re-execute and trace.

⚠️ So for trace_block_transactions method, we are gonna re-execute and trace all transactions within a block, but concerning trace_transactions method, we will only target and put the transactions needed into the second vector to get its trace.

Does this introduce a breaking change?

No ❌

Other information

@Tbelleng Tbelleng requested review from antiyro and jbcaron March 6, 2024 13:01
@Tbelleng Tbelleng self-assigned this Mar 6, 2024
crates/client/rpc/src/lib.rs Outdated Show resolved Hide resolved
crates/pallets/starknet/src/simulations.rs Outdated Show resolved Hide resolved
@jbcaron jbcaron self-requested a review March 6, 2024 13:28
@antiyro antiyro merged commit 2877687 into madara-alliance:main Mar 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants