Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: store key/value in --disble-root mode #97

Merged
merged 4 commits into from
May 3, 2024

Conversation

jbcaron
Copy link
Member

@jbcaron jbcaron commented May 3, 2024

feat: store key/value in --disble-root mode

Pull Request type

  • Feature

What is the current behavior?

What is the new behavior?

  • key/value are stored in --disable-root mode

Does this introduce a breaking change?

Other information

@jbcaron jbcaron requested review from cchudant and antiyro May 3, 2024 09:39
@jbcaron jbcaron self-assigned this May 3, 2024
Copy link
Member

@antiyro antiyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, better to store keys in disable

@jbcaron jbcaron requested a review from antiyro May 3, 2024 12:04
Copy link
Member

@antiyro antiyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now thanks

@jbcaron jbcaron merged commit 265c7c5 into madara-alliance:main May 3, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants