Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for old Ruby and Rails versions #171

Merged
merged 5 commits into from
Oct 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 11 additions & 80 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,79 +36,22 @@ jobs:
fail-fast: false
matrix:
include:
- gemfile: activerecord_5.0.0
ruby: '2.4'

- gemfile: activerecord_5.1.0
ruby: '2.4'

- gemfile: activerecord_5.2.0
ruby: '2.4'

- gemfile: activerecord_5.0.0
ruby: '2.5'

- gemfile: activerecord_5.1.0
ruby: '2.5'

- gemfile: activerecord_5.2.0
ruby: '2.5'

- gemfile: activerecord_6.0.0
ruby: '2.5'

- gemfile: activerecord_6.1.0
ruby: '2.5'

- gemfile: activerecord_5.0.0
ruby: '2.6'

- gemfile: activerecord_5.1.0
ruby: '2.6'

- gemfile: activerecord_5.2.0
ruby: '2.6'

- gemfile: activerecord_6.0.0
ruby: '2.6'

- gemfile: activerecord_6.1.0
ruby: '2.6'

- gemfile: activerecord_5.0.0
ruby: '2.7'

- gemfile: activerecord_5.1.0
ruby: '2.7'

- gemfile: activerecord_5.2.0
ruby: '2.7'

- gemfile: activerecord_6.0.0
ruby: '2.7'

- gemfile: activerecord_6.1.0
ruby: '2.7'

- gemfile: activerecord_7.0.8
ruby: '2.7'

- gemfile: activerecord_6.1.0
- gemfile: activerecord_6.1
ruby: '3.0'

- gemfile: activerecord_6.1.0
- gemfile: activerecord_6.1
ruby: '3.1'

- gemfile: activerecord_6.1.0
- gemfile: activerecord_6.1
ruby: '3.2'

- gemfile: activerecord_7.0.8
- gemfile: activerecord_7.0
ruby: '3.0'

- gemfile: activerecord_7.0.8
- gemfile: activerecord_7.0
ruby: '3.1'

- gemfile: activerecord_7.0.8
- gemfile: activerecord_7.0
ruby: '3.2'

- gemfile: activerecord_7.1
Expand All @@ -120,24 +63,13 @@ jobs:
- gemfile: activerecord_7.1
ruby: '3.2'

- gemfile: activerecord_5.1.0
ruby: 'jruby-9.3'

- gemfile: activerecord_5.2.0
ruby: 'jruby-9.3'

- gemfile: activerecord_6.0.0
ruby: 'jruby-9.3'

- gemfile: activerecord_6.1.0
ruby: 'jruby-9.3'

# waiting for https://github.com/jruby/activerecord-jdbc-adapter/issues/1125 to be addressed
# - gemfile: activerecord_7.0.1
# ruby: 'jruby-9.4'
- gemfile: activerecord_7.0
ruby: 'jruby-9.4'

name: ${{ matrix.gemfile }}, ruby ${{ matrix.ruby }}

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile
steps:
- uses: actions/checkout@v3

Expand All @@ -149,8 +81,7 @@ jobs:

- name: Bundle install
run: |
bundle config set gemfile "${GITHUB_WORKSPACE}/gemfiles/${{ matrix.gemfile }}.gemfile"
bundle install --jobs 4 --retry 3
bundle install

- name: Setup DB
run: |
Expand Down
20 changes: 2 additions & 18 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,26 +1,10 @@
# frozen_string_literal: true

appraise "activerecord-5.0.0" do
gem "activerecord", "~> 5.0.0"
end

appraise "activerecord-5.1.0" do
gem "activerecord", "~> 5.1.3"
end

appraise "activerecord-5.2.0" do
gem "activerecord", "~> 5.2.8"
end

appraise "activerecord-6.0.0" do
gem "activerecord", "~> 6.0.6"
end

appraise "activerecord-6.1.0" do
appraise "activerecord-6.1" do
gem "activerecord", "~> 6.1"
end

appraise "activerecord-7.0.8" do
appraise "activerecord-7.0" do
gem "activerecord", "~> 7.0.8"
end

Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,8 @@ Because this gem promotes attributes nested into the JSON column to first level

## Dependencies

- ActiveRecord >= 5.0
- Ruby > 3. Lower versions are not tested.
- ActiveRecord >= 6.1
- Postgres >= 9.4 (in order to use the [jsonb column type](http://www.postgresql.org/docs/9.4/static/datatype-json.html)).

## Upgrading
Expand Down
7 changes: 0 additions & 7 deletions gemfiles/activerecord_5.0.0.gemfile

This file was deleted.

7 changes: 0 additions & 7 deletions gemfiles/activerecord_5.1.0.gemfile

This file was deleted.

7 changes: 0 additions & 7 deletions gemfiles/activerecord_5.2.0.gemfile

This file was deleted.

7 changes: 0 additions & 7 deletions gemfiles/activerecord_6.0.0.gemfile

This file was deleted.

File renamed without changes.
File renamed without changes.
6 changes: 3 additions & 3 deletions jsonb_accessor.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ Gem::Specification.new do |spec|
spec.description = "Adds typed jsonb backed fields to your ActiveRecord models."
spec.homepage = "https://github.com/devmynd/jsonb_accessor"
spec.license = "MIT"
spec.required_ruby_version = ">= 2"
spec.required_ruby_version = ">= 3"

spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) || f.match(/png\z/) }
spec.bindir = "exe"
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.add_dependency "activerecord", ">= 5.0"
spec.add_dependency "activesupport", ">= 5.0"
spec.add_dependency "activerecord", ">= 6.1"
spec.add_dependency "activesupport", ">= 6.1"
if is_java
spec.add_dependency "activerecord-jdbcpostgresql-adapter", ">= 50.0"
else
Expand Down