Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OMP link errors in clang and icpx for cudacpp.mk #578

Closed
valassi opened this issue Dec 19, 2022 · 1 comment · Fixed by #596
Closed

Fix OMP link errors in clang and icpx for cudacpp.mk #578

valassi opened this issue Dec 19, 2022 · 1 comment · Fixed by #596
Assignees
@valassi

Comments

@valassi
Copy link
Member

valassi commented Dec 19, 2022

Fix OMP link errors in clang and icpx for cudacpp.mk

I have reenable OMP in cudacpp. It works in gcc, but link fails in icpx and clang.

Note that the fortran madevent links ok on both clang and icpx instead with openmp, it is only cudacpp that gives issues.

Note that there is a choice of linkers: gcc, nvcc or gfortran are used in different targets, for instance I think the madeent uses gfortran/FC.

I have fixed icpx without cuda, but not with cuda. As for clang I am not sure (I fixed icpx with static-intel, so not a clang solution)
This was referenced Dec 19, 2022
Open
Merged
valassi added a commit to valassi/madgraph4gpu that referenced this issue Dec 19, 2022
@valassi
[omp] ** COMPLETE OMP ** regenerate 5 mad and 6 sa - completed OMP re…
f9fed4f 
…enabling on gcc madgraph5#575 (not yet on icpx clang madgraph5#578)
valassi added a commit to valassi/madgraph4gpu that referenced this issue Dec 19, 2022
@valassi
[omp] regenerate 5 mad and 6 sa - completed OMP reenabling on gcc mad…
e7a3a0e 
…graph5#575 (not yet on icpx clang madgraph5#578)
@valassi valassi self-assigned this Feb 24, 2023
valassi added a commit to valassi/madgraph4gpu that referenced this issue Feb 24, 2023
@valassi
[omp] in ggttmad fix OMP link flags for clang (madgraph5#578)
1943097 
I added -lomp because "ldd check.exe" showed that libomp was used
valassi added a commit to valassi/madgraph4gpu that referenced this issue Feb 24, 2023
@valassi
[omp] in ggttmad fix OMP link flags for clang (madgraph5#578)
76b0d80 
I added -liomp5 because "ldd check.exe" showed that libomp was used
(probably -lomp would have been ok too, but there was a risk of mixing things up...)
valassi added a commit to valassi/madgraph4gpu that referenced this issue Feb 24, 2023
@valassi
[omp] improve comments about omp in clang/icx (madgraph5#578)
3cbc41b
@valassi valassi mentioned this issue Feb 24, 2023
Merged
@valassi
Copy link
Member Author

valassi commented Feb 24, 2023

This is fixed by MR #596

@valassi valassi closed this as completed Feb 24, 2023
valassi added a commit to valassi/madgraph4gpu that referenced this issue Feb 24, 2023
@valassi
[omp] in ggtt.mad disable OMP again on Apple clang (madgraph5#578) - …
bcb2404 
…will not fix this
valassi added a commit to valassi/madgraph4gpu that referenced this issue Feb 24, 2023
@valassi
[omp] backport to codegen the cudacpp.mk change for Apple clang (madg…
80aeaf8 
…raph5#578)
@valassi valassi mentioned this issue Mar 9, 2023
Closed
valassi added a commit to valassi/madgraph4gpu that referenced this issue Mar 9, 2023
@valassi
[icx] in ggtt.mad makefiles, clarify that OMP is not yet supported by…
b79f9c7 
… cudacpp in Apple clang (madgraph5#578 and madgraph5#604)
valassi added a commit to valassi/madgraph4gpu that referenced this issue Mar 10, 2023
@valassi
[icx] in ggtt.mad makefiles, clarify that OMP is not yet supported by…
3d1ab19 
… cudacpp in Apple clang (madgraph5#578 and madgraph5#604)
valassi added a commit to mg5amcnlo/mg5amcnlo_cudacpp that referenced this issue Aug 16, 2023
@valassi
[omp] backport to codegen the cudacpp.mk change for Apple clang (madg…
fb710ff 
…raph5/madgraph4gpu#578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valassi valassi

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@valassi