Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to compile on Windows ARM64 with MSVC #325

Open
GyrosGeier opened this issue Dec 11, 2017 · 0 comments
Open

Fails to compile on Windows ARM64 with MSVC #325

GyrosGeier opened this issue Dec 11, 2017 · 0 comments

Comments

@GyrosGeier
Copy link

When linking the shared library on ARM64:

link -nologo -debug -incremental:no -opt:ref -def:./win32/zlib.def -dll -implib:zdll.lib  -out:zlib1.dll -base:0x5A4C0000 adler32.obj compress.obj crc32.obj deflate.obj gzclose.obj gzlib.obj gzread.obj  gzwrite.obj infback.obj inflate.obj inftrees.obj inffast.obj trees.obj uncompr.obj zutil.obj  zlib1.res
 Creating library zdll.lib and object zdll.exp
 LINK : fatal error LNK1355: invalid base address 0x5A4C0000; ARM64 image cannot have base address below 4GB

This restriction was newly introduced in last week's compiler update, but it seems they have a reason for that.

Full build log
geraldcombs added a commit to geraldcombs/falcosecurity-libs that referenced this issue Jun 7, 2024
@geraldcombs
update(cmake): Build zlib using CMake on Windows
91eb837 
Build zlib using CMake on Windows instead of nmake. The nmakefile passes
"-base:0x5A4C0000" to the linker, which is too small on Arm64 and not
really needed or wanted on any platform these days.

madler/zlib#325

Signed-off-by: Gerald Combs <[email protected]>
@geraldcombs geraldcombs mentioned this issue Jun 7, 2024
Merged
geraldcombs added a commit to geraldcombs/falcosecurity-libs that referenced this issue Jun 26, 2024
@geraldcombs
update(cmake): Build zlib using CMake on Windows
07f8c37 
Build zlib using CMake on Windows instead of nmake. The nmakefile passes
"-base:0x5A4C0000" to the linker, which is too small on Arm64 and not
really needed or wanted on any platform these days.

madler/zlib#325

Signed-off-by: Gerald Combs <[email protected]>
poiana pushed a commit to falcosecurity/libs that referenced this issue Jun 27, 2024
@geraldcombs @poiana
update(cmake): Build zlib using CMake on Windows
fac0ae4 
Build zlib using CMake on Windows instead of nmake. The nmakefile passes
"-base:0x5A4C0000" to the linker, which is too small on Arm64 and not
really needed or wanted on any platform these days.

madler/zlib#325

Signed-off-by: Gerald Combs <[email protected]>
LucaGuerra pushed a commit to LucaGuerra/libs that referenced this issue Jul 31, 2024
@geraldcombs @LucaGuerra
update(cmake): Build zlib using CMake on Windows
853a549 
Build zlib using CMake on Windows instead of nmake. The nmakefile passes
"-base:0x5A4C0000" to the linker, which is too small on Arm64 and not
really needed or wanted on any platform these days.

madler/zlib#325

Signed-off-by: Gerald Combs <[email protected]>
LucaGuerra pushed a commit to LucaGuerra/libs that referenced this issue Jul 31, 2024
@geraldcombs @LucaGuerra
update(cmake): Build zlib using CMake on Windows
4142e3d 
Build zlib using CMake on Windows instead of nmake. The nmakefile passes
"-base:0x5A4C0000" to the linker, which is too small on Arm64 and not
really needed or wanted on any platform these days.

madler/zlib#325

Signed-off-by: Gerald Combs <[email protected]>
poiana pushed a commit to falcosecurity/libs that referenced this issue Aug 1, 2024
@geraldcombs @poiana
update(cmake): Build zlib using CMake on Windows
d62b2a0 
Build zlib using CMake on Windows instead of nmake. The nmakefile passes
"-base:0x5A4C0000" to the linker, which is too small on Arm64 and not
really needed or wanted on any platform these days.

madler/zlib#325

Signed-off-by: Gerald Combs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GyrosGeier