Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type of Requirement.specs is incorrect #78

Closed
wch opened this issue May 31, 2022 · 0 comments · Fixed by #95
Closed

Type of Requirement.specs is incorrect #78

wch opened this issue May 31, 2022 · 0 comments · Fixed by #95
Assignees
@madpah
Labels
enhancement

Comments

@wch
Copy link

wch commented May 31, 2022

The type of Requirement.specs is declared to be List[str]:

requirements-parser/requirements/requirement.py

Line 90 in 1ce9236

self.specs: List[str] = []

However, the actual type is List[Tuple[str, str]], like [('>', '1.5'), ('<', '1.6')].

The value is assigned here, and the type of the source value is declared as [list[tuple[str, str]]. The # type: ignore isn't needed on that line.

image
madpah added a commit that referenced this issue Apr 3, 2024
@madpah
fix: Type of Requirement.specs has been corrected as per #78
7001530 
Signed-off-by: Paul Horton <[email protected]>
@madpah madpah mentioned this issue Apr 3, 2024
Merged
@madpah madpah self-assigned this Apr 3, 2024
@madpah madpah linked a pull request Apr 3, 2024 that will close this issue
0.7.0 Release #95
Merged
madpah added a commit that referenced this issue Apr 3, 2024
@madpah
fix: Type of Requirement.specs has been corrected as per #78
0a3089f 
Signed-off-by: Paul Horton <[email protected]>
@madpah madpah closed this as completed in #95 Apr 3, 2024
madpah added a commit that referenced this issue Apr 3, 2024
@madpah
feat: Add support for Python 3.12 #93 via #94
16ffe88 
feat: Drop support for Python 3.7 as part of #91

fix: Publish anciliary files only to sdist #66 via #87 (thanks to Maxwell G <[email protected]>)

fix: Type of `Requirement.specs` was incorrect #78

fix: `-e` in `requirements.txt` did not handle local paths correctly #97

chore(dev-deps): Updated all development dependencies

chore(deps): include types-setuptools as dependency

Signed-off-by: Paul Horton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madpah madpah

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

0.7.0 Release madpah/requirements-parser
2 participants
@wch @madpah