Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging for Meteor.js, http://meteor.com #140

Closed
wants to merge 1 commit into from

Conversation

dandv
Copy link

@dandv dandv commented Nov 28, 2014

Hi Thomas,

I'm a Meteor.js dev and volunteer package maintainer for Meteor. I've learned about keymaster.js from a wrapper package that we had and got out of date, and thought it would be great to have a direct integration from you in Meteor's package repository.

This PR will let you directly publish updated versions of the library as they become available. All you have to do is create an account at https://meteor.com/ (click SIGN IN, then Create account). After you've done that, please let me know the name of the account, and I'll add you as a maintainer.

I've already published the current version of the package on Atmosphere (Meteor's package directory). When you release new versions, you'll be able to publish them to Atmosphere by running meteor/publish.sh.

Thanks & best regards,
Dan, official Meteor integrations team

@madrobby
Copy link
Owner

Hi there. I appreciate the PR but I will not add this. I can't add all package managers that people might want to use, simply because 1) I don't use them at all and can't possibly know if the code works or not (there's no tests, fwiw) and 2) it adds technical debt to the repository which I do not want to deal with.

I welcome package managers that don't require code changes.

@madrobby madrobby closed this Nov 28, 2014
@dandv
Copy link
Author

dandv commented Nov 28, 2014

I'm really sorry to hear this, after all the effort we've put in.

Would you reconsider if there were tests, and there were no changes to your code?

@dandv
Copy link
Author

dandv commented Nov 28, 2014

Keymaster is a great keyboard handling library, and adding it to Meteor's ecosystem will expose it to many new devs (Meteor has 20k+ stars on GitHub), likely bringing in new testers and contributors.

As for tests, meteor/test.js handles instantiation. The rest is independent of Meteor, so your existing test suite passing means that the library will function just fine with Meteor (which doesn't do any keyboard handling).

Your code isn't modified. Exporting is done through a separate file, meteor/export.js.

@madrobby
Copy link
Owner

I appreciate the effort put into this, however I can't add this.

I strongly suggest for Meteor to have centralized repository to store manifests/recipes/formulas (like Homebrew or CocoaPods). That way I wouldn't have to do anything, and someone else could easily keep files up-to-date for packing.

As a workaround, please feel free to fork this repository and add the meteor files there.

@BillyParadise
Copy link

That's too bad. Meteor rocks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants