Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using relative path for LESS crashes VS2013 #1321

Closed
ghost opened this issue Jul 16, 2014 · 13 comments
Closed

Using relative path for LESS crashes VS2013 #1321

ghost opened this issue Jul 16, 2014 · 13 comments

Comments

@ghost
Copy link

ghost commented Jul 16, 2014

When attempting to import LESS file the IDE crashes, the path is relative to the file and the folder exists in the directory tree.

Tree:
image

Code causing issue (pressing forward slash after this causes crash):
image

  • VS Details
    image
@am11
Copy link
Contributor

am11 commented Jul 17, 2014

The screenshot shows 1.0 as the version of installed WE, whereas the current stable version is 2.2 and current nightly build is at 2.2.6.1. I think we need to add the following in VSPackage.resx L126:

<data name="104" xml:space="preserve">   <!-- 104 is a weird name for 'Product ID' -->
   <value>2.2.6.1</value>
</data>

and automate it in PreBuildTask so it is updated with every build, reading the current version from .visxmanifest (which we manually change before the release).

If you aren't already, can you reproduce it with version 2.2.6.1 nightly?

@am11
Copy link
Contributor

am11 commented Jul 21, 2014

@blowsie, can you verify this as well?

@blowsie
Copy link
Contributor

blowsie commented Jul 22, 2014

@am11 this works fine for me in 2.2.6.1 nightly, however the version number in Help > About does show v1.0.

image

I would also add that @webkeg's intellisense doesn't seem to be working, maybe its a related issue?
untitled

@am11
Copy link
Contributor

am11 commented Jul 22, 2014

Yeah the versioning should be automated.

Maybe he is using some old version and not the latest nightly?

I am going to make build now. v2.2.7. But I have upgraded to VS Update 3 RC. If I share a release with you, can you confirm if its working with Update 2? (I will change the manifest file so Update 2 wont choke)

@blowsie
Copy link
Contributor

blowsie commented Jul 22, 2014

@am11 Sure

@am11
Copy link
Contributor

am11 commented Jul 22, 2014

@blowsie here you go http://1drv.ms/1qAjKXM. Its in v2.2.7 folder. :)

@blowsie
Copy link
Contributor

blowsie commented Jul 22, 2014

@am11 Thanks, busy at the moment will do in the next few hours.

@am11
Copy link
Contributor

am11 commented Jul 22, 2014

Its ok. TYT!
Notice the version in About screen would be 2.2.7.

@blowsie
Copy link
Contributor

blowsie commented Jul 22, 2014

2.2.7

image


Other issues:

  • Menu Missing:
    image
  • LESS / JS etc, compilers dont appear to be doing anything at all.

So overall its a bit broken :(

Some logs:

Exception Type       : System.ComponentModel.Composition.CompositionException
Exception Message    : The composition produced a single composition error. The root cause is provided below. Review the CompositionException.Errors property for more detailed information.

1) No exports were found that match the constraint: 
    ContractName    MadsKristensen.EditorExtensions.Compilers.ProjectCompiler
    RequiredTypeIdentity    MadsKristensen.EditorExtensions.Compilers.ProjectCompiler

Resulting in: Cannot set import 'MadsKristensen.EditorExtensions.BuildMenu.Compiler (ContractName="MadsKristensen.EditorExtensions.Compilers.ProjectCompiler")' on part 'MadsKristensen.EditorExtensions.BuildMenu'.
Element: MadsKristensen.EditorExtensions.BuildMenu.Compiler (ContractName="MadsKristensen.EditorExtensions.Compilers.ProjectCompiler") -->  MadsKristensen.EditorExtensions.BuildMenu

Exception Stack Trace:    at System.ComponentModel.Composition.CompositionResult.ThrowOnErrors(AtomicComposition atomicComposition)
   at System.ComponentModel.Composition.Hosting.ImportEngine.SatisfyImportsOnce(ComposablePart part)
   at System.ComponentModel.Composition.Hosting.CompositionContainer.SatisfyImportsOnce(ComposablePart part)
   at System.ComponentModel.Composition.AttributedModelServices.SatisfyImportsOnce(ICompositionService compositionService, Object attributedPart)
   at MadsKristensen.EditorExtensions.BuildMenu..ctor(DTE2 dte, OleMenuCommandService mcs)
   at MadsKristensen.EditorExtensions.WebEssentialsPackage.<Initialize>d__3.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.AsyncMethodBuilderCore.<ThrowAsync>b__0(Object state)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(Object source, Delegate method, Object args, Int32 numArgs, Delegate catchHandler)
Exception Data:
Key: System.Object, Value: [null]
Exception Type       : System.ArgumentNullException
Exception Message    : Value cannot be null.
Parameter name: menuSite
Exception Stack Trace:    at System.Windows.Input.InputManager.PushMenuMode(PresentationSource menuSite)
   at System.Windows.Controls.Primitives.MenuBase.PushMenuMode(Boolean isAcquireFocusMenuMode)
   at System.Windows.Controls.Primitives.MenuBase.OnPreviewKeyboardInputProviderAcquireFocus(Object sender, KeyboardInputProviderAcquireFocusEventArgs e)
   at System.Windows.Input.KeyboardInputProviderAcquireFocusEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.UIElement.RaiseTrustedEvent(RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs args, Boolean trusted)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
   at System.Windows.Input.KeyboardDevice.TryChangeFocus(DependencyObject newFocus, IKeyboardInputProvider keyboardInputProvider, Boolean askOld, Boolean askNew, Boolean forceToNullIfFailed)
   at System.Windows.Input.KeyboardDevice.Focus(DependencyObject focus, Boolean askOld, Boolean askNew, Boolean forceToNullIfFailed)
   at System.Windows.Input.KeyboardDevice.Focus(IInputElement element)
   at System.Windows.UIElement.Focus()
   at System.Windows.Controls.MenuItem.FocusOrSelect()
   at System.Windows.Controls.MenuItem.MouseEnterInMenuMode(MenuItemRole role)
   at System.Windows.Controls.MenuItem.MouseEnterHelper()
   at System.Windows.Controls.MenuItem.OnMouseEnter(MouseEventArgs e)
   at System.Windows.UIElement.OnMouseEnterThunk(Object sender, MouseEventArgs e)
   at System.Windows.Input.MouseEventArgs.InvokeEventHandler(Delegate genericHandler, Object genericTarget)
   at System.Windows.RoutedEventArgs.InvokeHandler(Delegate handler, Object target)
   at System.Windows.RoutedEventHandlerInfo.InvokeHandler(Object target, RoutedEventArgs routedEventArgs)
   at System.Windows.EventRoute.InvokeHandlersImpl(Object source, RoutedEventArgs args, Boolean reRaised)
   at System.Windows.UIElement.RaiseEventImpl(DependencyObject sender, RoutedEventArgs args)
   at System.Windows.UIElement.RaiseEvent(RoutedEventArgs e)
   at System.Windows.MouseOverProperty.FireNotifications(UIElement uie, ContentElement ce, UIElement3D uie3D, Boolean oldValue)
   at System.Windows.ReverseInheritProperty.FirePropertyChangeInAncestry(DependencyObject element, Boolean oldValue, DeferredElementTreeState treeState, Action`2 originChangedAction)
   at System.Windows.ReverseInheritProperty.FirePropertyChangeInAncestry(DependencyObject element, Boolean oldValue, DeferredElementTreeState treeState, Action`2 originChangedAction)
   at System.Windows.ReverseInheritProperty.FirePropertyChangeInAncestry(DependencyObject element, Boolean oldValue, DeferredElementTreeState treeState, Action`2 originChangedAction)
   at System.Windows.ReverseInheritProperty.OnOriginValueChanged(DependencyObject oldOrigin, DependencyObject newOrigin, IList`1 otherOrigins, DeferredElementTreeState& oldTreeState, Action`2 originChangedAction)
   at System.Windows.Input.MouseDevice.ChangeMouseOver(IInputElement mouseOver, Int32 timestamp)
   at System.Windows.Input.MouseDevice.PreNotifyInput(Object sender, NotifyInputEventArgs e)
   at System.Windows.Input.InputManager.ProcessStagingArea()
   at System.Windows.Input.InputManager.ProcessInput(InputEventArgs input)
   at System.Windows.Input.InputProviderSite.ReportInput(InputReport inputReport)
   at System.Windows.Interop.HwndMouseInputProvider.ReportInput(IntPtr hwnd, InputMode mode, Int32 timestamp, RawMouseActions actions, Int32 x, Int32 y, Int32 wheel)
   at System.Windows.Interop.HwndMouseInputProvider.FilterMessage(IntPtr hwnd, WindowMessage msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at System.Windows.Interop.HwndSource.InputFilterMessage(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndWrapper.WndProc(IntPtr hwnd, Int32 msg, IntPtr wParam, IntPtr lParam, Boolean& handled)
   at MS.Win32.HwndSubclass.DispatcherCallbackOperation(Object o)
   at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
   at MS.Internal.Threading.ExceptionFilterHelper.TryCatchWhen(Object source, Delegate method, Object args, Int32 numArgs, Delegate catchHandler)
Exception Data:
Key: System.Object, Value: [null]

@madskristensen
Copy link
Owner

Please uninstall and reinstall 2.2.7. I uploaded a version of 2.2.7 yesterday that was faulty

@blowsie
Copy link
Contributor

blowsie commented Jul 22, 2014

I installed it from the link @am11 gave me just a few minutes ago.

Using update 2 by the way.

@am11
Copy link
Contributor

am11 commented Jul 22, 2014

@madskristensen apparently its not working with Update 2. I changed the .visxmanifest file to older version before building the release:

<?xml version="1.0" encoding="utf-8"?>
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
  <Metadata>
    <Identity Id="5fb7364d-2e8c-44a4-95eb-2a382e30fec8" Version="2.2.7" Language="en-US" Publisher="Mads Kristensen" />
    <DisplayName>Web Essentials 2013 for Update 2</DisplayName>
    <Description xml:space="preserve">Adds many useful features to Visual Studio for web developers. Requires VS2013 Update 2 RTM</Description>
    <MoreInfo>http://vswebessentials.com/</MoreInfo>
    <License>License.txt</License>
    <GettingStartedGuide>http://vswebessentials.com/changelog</GettingStartedGuide>
    <ReleaseNotes>http://vswebessentials.com/changelog</ReleaseNotes>
    <Icon>Resources/Images/WebEssentials2012logo.png</Icon>
    <PreviewImage>Resources/Images/preview.png</PreviewImage>
    <Tags>css, javascript, html, less, coffeescript, json</Tags>
  </Metadata>
  <Installation InstalledByMsi="false">
    <InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[12.0.30501,13.0)" />
    <InstallationTarget Id="Microsoft.VisualStudio.VWDExpress" Version="[12.0.30501,13.0)" />
  </Installation>
  <Dependencies>
    <Dependency Id="Microsoft.Framework.NDP" DisplayName="Microsoft .NET Framework" d:Source="Manual" Version="4.5" />
    <Dependency Id="Microsoft.VisualStudio.MPF.12.0" DisplayName="Visual Studio MPF 12.0" d:Source="Installed" Version="[12.0,13.0)" />
  </Dependencies>
  <Assets>
    <Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="Project" d:ProjectName="%CurrentProject%" Path="|%CurrentProject%;PkgdefProjectOutputGroup|" />
    <Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="File" Path="registry.pkgdef" />
    <Asset Type="Microsoft.VisualStudio.MefComponent" d:Source="Project" d:ProjectName="%CurrentProject%" Path="|%CurrentProject%|" />
    <Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="File" Path="CSS\Snippets\snippets.pkgdef" />
  </Assets>
</PackageManifest>

Here is the link to release http://1drv.ms/1qAjKXM (v2.2.7)

@am11
Copy link
Contributor

am11 commented Jul 24, 2014

@madskristensen there is nothing to fix about the original issue reported here.

I think it was stable v2.2 issue which was fixed in recent nightly builds; that's why @blowsie and I aren't able reproduce it.

This can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants