Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full selector tooltip no showing on nested LESS selectors #371

Closed
madskristensen opened this issue Dec 29, 2013 · 5 comments · Fixed by #828
Closed

Full selector tooltip no showing on nested LESS selectors #371

madskristensen opened this issue Dec 29, 2013 · 5 comments · Fixed by #828
Labels

Comments

@madskristensen
Copy link
Owner

Example:

header{
    div{
        display: block;
    }
}

When hovering over the div selector, no tooltip shows the full path: header div. However, hovering the display declaration will. The tooltip should only show on selectors and not on declarations

@am11
Copy link
Contributor

am11 commented Mar 11, 2014

Even in simple CSS, the tooltip only shows specificity for selectors and example and browser compatibility in case of declaration.

Should we change the behavior for all, CSS, LESS and SCSS?

@madskristensen
Copy link
Owner Author

To what? Specificity only applies to selectors

@am11
Copy link
Contributor

am11 commented Mar 14, 2014

Currently, tooltips in CSS, LESS and SCSS behaves the following way:

Declarations: Examples and browser icons.
Selectors: Selectors specificity.

The tooltip should only show on selectors and not on declarations

Should we change this behavior for all three stylesheet content types?

@madskristensen
Copy link
Owner Author

Ahh, now I get what you mean. No, we should keep the current behavior. It's because this is a bug where the full selector tooltip is shown when hovering a declaration instead of the selector.

@am11
Copy link
Contributor

am11 commented Mar 14, 2014

Cool.

Looks like this is magically resolved. I can't reproduce this specific issue. 👍

However, there are some major snags when calculating specificity. For instance, mixins scenarios which @spadapet mentioned earlier and also the loop structures which SCSS offers to save repetition of code. Those we may be able to fix using compiled code via map files (if the suitable options are enabled in settings). See #783 (comment). This would guarantee the correctness of calculated specificity, displayed in selector's tooltip.

am11 added a commit to am11/WebEssentials2013 that referenced this issue Mar 31, 2014
am11 added a commit to am11/WebEssentials2013 that referenced this issue Mar 31, 2014
madskristensen added a commit that referenced this issue Mar 31, 2014
Tooltip: Show full selector path. (#371)
am11 added a commit to am11/WebEssentials2013 that referenced this issue Apr 1, 2014
SLaks pushed a commit to SLaks/WebEssentials2013 that referenced this issue May 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants