TS Intellisense Generation doesn't support inheritance

[craigktreasure]

In the case of the following two classes where the two classes are in two different files:

public class BaseClass {
    public string Title { get; set; }
}

public class Model: BaseClass {
    public string SomeProp { get; set; }
}

It would be nice if the Intellisense file added an "extends BaseClass". It doesn't currently, which means you lose the properties in BaseClass.

[SLaks]

Emitting this in JS would be more complicated; we'd need to pick an inheritance paradigm. (probably http://blog.slaks.net/2013-09-03/traditional-inheritance-in-javascript/)

[DerAlbertCom]

In TS it would be not so hard. But first we should do a Bundle or per Folder generation of multiple TS/JS Files files.
The JS/Files are only for Intellisens so that we can simply pick one which is understood by Visual Studio. We can simple generate a JS Function with all the properties and no inheritence.

[SLaks]

The JS files are not only used by VS; if you write new SomeType(), that will only work at runtime if the generated JS file is included.

[DerAlbertCom]

Then we must support several inheritance styles 🌵

[nicholashead]

This is literally the only thing holding us back from using the auto-generated TypeScript feature. Forgive me, but can't this just be implemented for TypeScript for now (using the "extends" keyword) and leave it out of the JS definition files? It doesn't seem to make sense to hold back half of this feature.

[craigktreasure]

Couldn't agree more. I'm getting tired of having to edit the generated file every time i touch a class.

[DerAlbertCom]

@nicholashead @craigktreasure the power of open source, simple add it (don't forgert the unit tests) ;)

If nobody take this, i will do it, next week.

[nicholashead]

@DerAlbertCom - yep, for sure. I'm not demanding it or anything! Just adding a +1 to the idea of someday supporting it in TypeScript.

[am11]

In IntellisenseParser.ProcessClass(_, __), we can use something like:

IEnumerable<CodeClass> baseClasses = cc.Bases.Cast<CodeClass>()
                                       .Where(c => c.FullName != "System.Object");

to collect base classes.

Couple of questions:

• Should we generate a separate intellisense file for each base class, same as the current class?
  • Should we generate intellisense for the entire base-class file or just the base class element (in situations where base class is in a file with multiple classes)?
• Should we stop at immediate ancestor or keep collecting parents until it hits System.Object?
• Should we consider interfaces / abstract classes or ignore them?
  • What will happen in multiple interface inheritance scenario?
  • What is the expected behavior for virtual and override properties?

[am11]

This is implemented by 73da2b1.

Please test with this build http://1drv.ms/1fv87dl.

[am11]

@madskristensen, this is fixed. Please release a nightly, so peeps can test it. :)

---

@craigktreasure, @DerAlbertCom, @nicholashead, @MissFishie, @gcastre: Please test this feature in (upcoming) nightly. We need to fix as many bugs as possible before the next stable release.

Also, please contribute adding the test cases (especially the tricky ones, recursive file reference, with multiple classes etc.) and other OOP scenarios where it could choke. I handled some which I could think of. But I suspect there must be some crafty ways to bring it down to its knees. ⬇️

TIA.

[madskristensen]

I just released 2.0.9. Thanks

[am11]

Great! Thanks.

Sent from my Windows Phone

---

From: Mads Kristensenmailto:[email protected]
Sent: ‎4/‎26/‎2014 3:16 AM
To: madskristensen/WebEssentials2013mailto:[email protected]
Cc: Adeel Mujahidmailto:[email protected]
Subject: Re: [WebEssentials2013] TS Intellisense Generation doesn't support inheritance (#495)

I just released 2.0.9. Thanks

---

Reply to this email directly or view it on GitHub:
#495 (comment)