Various header translator refactors #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
bug
madsmtm
force-pushed
the
various-header-translator-refactors
branch
7 times, most recently
from
3e6f8f9 to
b17d75a
Compare
madsmtm
force-pushed
the
various-header-translator-refactors
branch
from
b17d75a to
22aba92
Compare
|
So... It felt like each change I made here was a step forwards, but honestly a lot of things just got more complex... Oh well, live an learn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically redid the whole "parse lifetime from a string"-part, and tweaked a lot of other small things (a lot of these were small irritating things that were preventing me from doing "real" work like #328)