Skip to content

Commit

Permalink
- upgrade helm-docs to 1.11
Browse files Browse the repository at this point in the history
- update helm docs
  • Loading branch information
t83714 committed Apr 28, 2023
1 parent f3ff8c7 commit 94e96e0
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Check Helm Chart Document
run: |
code=0
docker run --rm -v "$(pwd):/helm-docs" -u $(id -u) jnorwood/helm-docs:v1.5.0 -t ./README.md.gotmpl -o ../../README.md || code=$?;
yarn helm-docs || code=$?;
if [ "$code" != "0" ]; then
echo "Failed to run helm-docs!";
exit 1;
Expand All @@ -37,7 +37,7 @@ jobs:
git ls-files -m | grep -i readme.md || code=$?;
if [ "$code" == "0" ]; then
echo -e "Some of helm chart docs are required to be updated using the [helm-docs](https://github.com/norwoodj/helm-docs) tool. \n
Please run helm-docs (v1.5.0) at project root, review & commit docs changes and push a new commit.";
Please run helm-docs (v1.11.0) at project root, review & commit docs changes and push a new commit.";
exit 1;
else
echo -e "helm docs check passed. helm docs update is not required.";
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Check Helm Chart Document
run: |
code=0
docker run --rm -v "$(pwd):/helm-docs" -u $(id -u) jnorwood/helm-docs:v1.5.0 -t ./README.md.gotmpl -o ../../README.md || code=$?;
yarn helm-docs || code=$?;
if [ "$code" != "0" ]; then
echo "Failed to run helm-docs!";
exit 1;
Expand All @@ -41,7 +41,7 @@ jobs:
git ls-files -m | grep -i readme.md || code=$?;
if [ "$code" == "0" ]; then
echo -e "Some of helm chart docs are required to be updated using the [helm-docs](https://github.com/norwoodj/helm-docs) tool. \n
Please run helm-docs (v1.5.0) at project root, review & commit docs changes and push a new commit.";
Please run helm-docs (v1.11.0) at project root, review & commit docs changes and push a new commit.";
exit 1;
else
echo -e "helm docs check passed. helm docs update is not required.";
Expand Down
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,13 @@ Kubernetes: `>= 1.21.0`
| config.basicAuthSecretName | string | `nil` | You can set this value to supply basic auth username & password. The secret must have two keys: `username` & `password`. |
| config.basicAuthUsername | string | `nil` | basic auth username. You can also passing this value via secret. To do so, set `basicAuthSecretName` to the secret name. |
| config.id | string | `"default-csw-connector"` | |
| config.usePostRequest | bool | `false` | |
| config.name | string | `nil` | Friendly readable name. Compulsory. |
| config.outputSchema | string | http://www.isotc211.org/2005/gmd | Desired output schema to be requested from CSW service as URI |
| config.pageSize | int | `100` | When crawling through from beginning to end, how big should the individual requests be in records? |
| config.schedule | string | "0 14 * * 6" i.e. 12am Sydney time on Sunday | Crontab schedule for how often this should happen. |
| config.sourceUrl | string | `nil` | The base URL of the place to source data from. Compulsory. |
| config.typeNames | string | gmd:MD_Metadata | Record type expected to be returned from CSW service as XML tag name |
| config.usePostRequest | bool | `false` | Whether or not use POST request to call getRecords API |
| defaultImage.imagePullSecret | bool | `false` | |
| defaultImage.pullPolicy | string | `"IfNotPresent"` | |
| defaultImage.repository | string | `"ghcr.io/magda-io"` | |
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"docker-build-prod": "create-docker-context-for-node-component --build --push --tag auto",
"retag-and-push": "retag-and-push",
"helm-lint": "helm lint deploy/magda-csw-connector -f deploy/test-deploy.yaml",
"helm-docs": "helm-docs -t ./README.md.gotmpl -o ../../README.md",
"helm-docs": "docker run --rm -v \"$(pwd):/helm-docs\" -u $(id -u) jnorwood/helm-docs:v1.11.0 -t ./README.md.gotmpl -o ../../README.md",
"update-all-charts": "helm dep up ./deploy/magda-csw-connector",
"add-all-chart-version-changes": "git ls-files -m | grep Chart.yaml | xargs git add && git ls-files -m | grep Chart.lock | xargs git add",
"add-all-helm-docs-changes": "yarn helm-docs && git ls-files -m | grep -i readme.md | xargs git add",
Expand Down

0 comments on commit 94e96e0

Please sign in to comment.