Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use multi-stage builds to build magda-scss-compile #3317

Closed
t83714 opened this issue Mar 1, 2022 · 1 comment
Closed

Use multi-stage builds to build magda-scss-compile #3317

t83714 opened this issue Mar 1, 2022 · 1 comment
Labels
feature request
Milestone
Next (v2.0.0)

Comments

@t83714
Copy link
Contributor

t83714 commented Mar 1, 2022

magda-scss-compile requires Debian Linux full base image for compiling node-sass.

Compared with the Alpine Linux base image, it increases the image size by around 300MB.

However, by adopting multi-stage builds, it's possible to use the Debian Linux full image for compiling node-sass only and still use the Alpine Linux image as the base image.
@t83714 t83714 added this to the v1.2.1 milestone Mar 1, 2022
@t83714 t83714 mentioned this issue Mar 1, 2022
Closed
@t83714 t83714 modified the milestones: v1.2.1, v1.2.2 Mar 28, 2022
@t83714 t83714 modified the milestones: v1.2.2, 1.3.1 May 3, 2022
@t83714 t83714 modified the milestones: 1.3.1, Next (v2.0.0) Jul 29, 2022
t83714 added a commit that referenced this issue Jul 30, 2022
@t83714
#3317 Use multi-stage builds to build magda-scss-compile
07b8ee5
@t83714 t83714 mentioned this issue Aug 1, 2022
Merged
2 tasks
@t83714
Copy link
Contributor Author

t83714 commented Aug 1, 2022

closed via PR: #3386

@t83714 t83714 closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
Next (v2.0.0)
Development

No branches or pull requests
1 participant
@t83714