-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/3315 New Integration test facility & add integration tests for auth #3344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- upgrade pg to 7.18.2
- use latest dockerode-compose forked commit
- add public create user API
- make create / update user return current user data - make `displayName` & `email` compulsory field when create user
… backwards compatible ) - better error message - make AuthApiClient use api endpoint at `/public/users` (/public/user will be removed in future)
…" anymore. i.e. A draft dataset must has "pulishing" aspect `state` field set to "draft". Our frontend will always create draft dataset with "publishing" aspect. Thus, this change won't impact our frontend.
- make new int-tests a compulsory step for all release jobs
- add `/v0/live` & `/v0/ready` endpoint to indexer - ServiceRuner: auth service is not enabled by default - ServiceRuner: index setup will be performed after elastic search is online
tested in pipelines & locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes
Checklist