Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/3315 New Integration test facility & add integration tests for auth #3344

Merged
merged 76 commits into from
Apr 21, 2022

Conversation

t83714
Copy link
Contributor

@t83714 t83714 commented Apr 14, 2022

What this PR does

Fixes

Checklist

  • There are unit tests to verify my changes are correct
  • I've updated CHANGES.md with what I changed.

t83714 added 30 commits April 5, 2022 23:44
- use latest dockerode-compose forked commit
- add public create user API
- make create / update user return current user data
- make `displayName` & `email` compulsory field when create user
… backwards compatible )

- better error message
- make AuthApiClient use api endpoint at `/public/users` (/public/user will be removed in future)
…" anymore.

i.e. A draft dataset must has "pulishing" aspect `state` field set to "draft".
Our frontend will always create draft dataset with "publishing" aspect. Thus, this change won't impact our frontend.
- make new int-tests a compulsory step for all release jobs
@t83714 t83714 marked this pull request as ready for review April 21, 2022 00:29
@t83714
Copy link
Contributor Author

t83714 commented Apr 21, 2022

tested in pipelines & locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant