Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arm64 arch #263

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Support arm64 arch #263

merged 1 commit into from
Oct 20, 2022

Conversation

jmontroy90
Copy link
Contributor

@jmontroy90 jmontroy90 commented Oct 19, 2022

Support ARM64 for architecture.

Fixes testing for the latest magefile version (v1.14.0) on ARM-based machines (most notably the new M1 / M2 Apple machines). Without this, tests were looking for a 32-bit Linux binary in tests, which is no longer produced by the upstream magefile repo, and wouldn't be right anyway.

Error output:

#13 6.453 Mage version found: v1.14.0
#13 6.454 Downloading https://github.com/magefile/mage/releases/download/v1.14.0/mage_1.14.0_Linux-32bit.tar.gz...
#13 6.454 ::debug::Downloading https://github.com/magefile/mage/releases/download/v1.14.0/mage_1.14.0_Linux-32bit.tar.gz
#13 6.454 ::debug::Destination /tmp/github_runner/b8051a76-30f0-4d00-b74c-6b9af3fcdb5e
#13 6.557 ::debug::Failed to download from "https://github.com/magefile/mage/releases/download/v1.14.0/mage_1.14.0_Linux-32bit.tar.gz". Code(404) Message(Not Found)

Now, fixed result is that docker buildx bake test passes successfully.

Note: I regenerated the dist/ artifacts as needed too and committed those. I'm no TypeScript / Javascript dev, so hopefully that all looks okay.

@jmontroy90 jmontroy90 requested a review from crazy-max as a code owner October 19, 2022 18:22
src/installer.ts Outdated Show resolved Hide resolved
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@crazy-max crazy-max merged commit 2c19511 into magefile:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants