Skip to content
This repository has been archived by the owner on Apr 29, 2019. It is now read-only.

MAGETWO-34709 Changing empty label value for first option on dropdown filters. #120

Merged
merged 1 commit into from
Oct 27, 2018
Merged

MAGETWO-34709 Changing empty label value for first option on dropdown filters. #120

merged 1 commit into from
Oct 27, 2018

Conversation

valentinboyanov
Copy link
Contributor

Description

We have fixed the "empty" option to allow the user to not select any of the options provided on the dropdown filters.

Fixed Issues

  1. [MAGETWO-34709] Export Customers Main File: invalid fields are available in export filter #62: [MAGETWO-34709] Export Customers Main File: invalid fields are available in export filter

Manual testing scenarios

  1. Make sure you have sample data to test
  2. Go to System -> Export in Admin panel
  3. Select Customer Main File entity type
  4. Select Female gender in Filter column
  5. Try to drop (remove) this filter to export both genders (without page reload)
  6. Download the file

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 8, 2018

CLA assistant check
All committers have signed the CLA.

@valentinboyanov
Copy link
Contributor Author

valentinboyanov commented Oct 8, 2018

Team: @dbolufer @davidselo @valentinboyanov

@magento-engcom-team
Copy link
Contributor

@valentinboyanov thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit e258878 into magento-engcom:2.3-develop Oct 27, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 27, 2018
@dmanners
Copy link
Contributor

Thank you @valentinboyanov for this pull request. It has now been merged into 2.3-develop.

Great job.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants