Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDVA-33704: Cant get in-store pick up to work #10

Closed
wants to merge 2 commits into from

Conversation

ikruchynskyi
Copy link

Backport from: MC-40772

Description (*)

Fixed Issues (if relevant)

  1. Fixes magento/inventory#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@@ -50,7 +52,10 @@ define([

return storage
.get(serviceUrl, {}, false)
.then(function (address) {
.then(function (result) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a part of the hotfix, it is a fix for this issue: magento#3209
Commit: https://github.com/magento-sparta/inventory/commit/b7e39669cb112432bc98cb0aca08431adc509773

I guess it was added by accident

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thank you!

@ilima-ebay ilima-ebay closed this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants