This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Layout xml #2051
Closed
Closed
Layout xml #2051
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
--- | ||
layout: default | ||
group: coding-standards | ||
subgroup: Coding standards | ||
title: Layout XML Coding Standards | ||
menu_title: Layout XML Coding Standards | ||
menu_order: 100 | ||
contributor_name: SwiftOtter Studios | ||
contributor_link: https://swiftotter.com/ | ||
version: 2.1 | ||
github_link: coding-standards/layout-coding-standard.md | ||
--- | ||
|
||
# Layout XML Coding Standard | ||
|
||
### Name attribute | ||
|
||
The `name` attribute should adhere to the guidelines listed below. The `name` attribute should: | ||
|
||
- Should explain element's purpose rather than its position on the page . | ||
- Be unique to the module that declares it by prepending it with module's namespace as `<vendor>.<module>` | ||
- Have segments separated by a `.` (period). | ||
- Be all lowercase. | ||
- Never use `_` (underscores). | ||
|
||
*Example:* | ||
|
||
```xml | ||
<block name="magento.catalog.product.preview"> | ||
<block name="magento.catalog.price"/> | ||
</block> | ||
``` | ||
|
||
### As attribute | ||
|
||
The `as` attribute should follow the guidelines below. The value of `as`: | ||
|
||
- Only needs to be unique to the block that contains it. | ||
- Should be as concise as possible, but with enough clarity to be understood within the block. | ||
- Can use an `_` (underscore) as a separator. | ||
- Should only be added if necessary. | ||
- Should be all lowercase. | ||
|
||
|
||
*Example:* | ||
|
||
```xml | ||
<block name="magento.catalog.product.preview"> | ||
<block name="magento.catalog.total.price" as="total_price"/> | ||
</block> | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I like this idea. However, I'm a bit hesitant because literally none of the core does this. I was hoping to keep it compatible with at least the general principle of what is already in the core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be done for the new layouts. So far it's just my idea, I'll be discussing it more. Thanks for your feedback.