Skip to content
This repository has been archived by the owner on Nov 19, 2024. It is now read-only.

Layout xml #2051

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions guides/v2.1/coding-standards/layout-coding-standard.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
---
layout: default
group: coding-standards
subgroup: Coding standards
title: Layout XML Coding Standards
menu_title: Layout XML Coding Standards
menu_order: 100
contributor_name: SwiftOtter Studios
contributor_link: https://swiftotter.com/
version: 2.1
github_link: coding-standards/layout-coding-standard.md
---

# Layout XML Coding Standard

### Name attribute

The `name` attribute should adhere to the guidelines listed below. The `name` attribute should:

- Should explain element's purpose rather than its position on the page .
- Be unique to the module that declares it by prepending it with module's namespace as `<vendor>.<module>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I like this idea. However, I'm a bit hesitant because literally none of the core does this. I was hoping to keep it compatible with at least the general principle of what is already in the core.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be done for the new layouts. So far it's just my idea, I'll be discussing it more. Thanks for your feedback.

- Have segments separated by a `.` (period).
- Be all lowercase.
- Never use `_` (underscores).

*Example:*

```xml
<block name="magento.catalog.product.preview">
<block name="magento.catalog.price"/>
</block>
```

### As attribute

The `as` attribute should follow the guidelines below. The value of `as`:

- Only needs to be unique to the block that contains it.
- Should be as concise as possible, but with enough clarity to be understood within the block.
- Can use an `_` (underscore) as a separator.
- Should only be added if necessary.
- Should be all lowercase.


*Example:*

```xml
<block name="magento.catalog.product.preview">
<block name="magento.catalog.total.price" as="total_price"/>
</block>
```