magento/graphql-ce#1009: [Test Coverage] Cover exception in SalesGraphQl\Model\Resolver\Orders

[atwixfirster]

Description (*)

Pull request fixes #1009 [Test Coverage] Cover exception in SalesGraphQl\Model\Resolver\Orders issue.

Fixed Issues (if relevant)

1. Invoice increment id uses wrong entity type magento2#1009: [Test Coverage] Cover exception in SalesGraphQl\Model\Resolver\Orders

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Thank you!

[lenaorobei]

I believe \Magento\GraphQl\Sales\OrdersTest is better place for this test.
Please consider renaming it as well. For example to testOrdersQueryNotAuthorized.

[atwixfirster]

I believe \Magento\GraphQl\Sales\OrdersTest is better place for this test.
Please consider renaming it as well. For example to testOrdersQueryNotAuthorized.

done @lenaorobei

Thanks

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-6160 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[ghost]

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.