This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 154
Added URL rewrites data to the product interface #107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paliarush
added
requires-documentation
requires-tests
PRs which require GraphQL tests
labels
Jul 2, 2018
12 tasks
vkublytskyi
reviewed
Jul 26, 2018
use Magento\UrlRewriteGraphQl\Model\Resolver\UrlRewrite\CustomUrlLocatorInterface; | ||
|
||
/** | ||
* UrlRewrite field resolver, used for GraphQL request processing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As EntityUrl and UrlRewrite are pretty similar it is better to describe their purpose in class comments (now both classes have same description so to understand what is needed source code should be explored)
naydav
reviewed
Sep 5, 2018
@@ -280,6 +280,7 @@ interface ProductInterface @typeResolver(class: "Magento\\CatalogGraphQl\\Model\ | |||
manufacturer: Int @doc(description: "A number representing the product's manufacturer") | |||
categories: [CategoryInterface] @doc(description: "The categories assigned to a product") @resolver(class: "Magento\\CatalogGraphQl\\Model\\Resolver\\Categories") | |||
canonical_url: String @doc(description: "Canonical URL") @resolver(class: "Magento\\CatalogGraphQl\\Model\\Resolver\\Product\\CanonicalUrl") | |||
url_rewrites: [UrlRewrite] @doc(description: "URL rewrites list") @resolver(class: "Magento\\UrlRewriteGraphQl\\Model\\Resolver\\UrlRewrite") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need to move all of this functionality to CatalogUrlRewriteGraphQl
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 14, 2018
2.3 dev pan 2.3.6
naydav
suggested changes
Sep 17, 2018
) { | ||
$this->urlFinder = $urlFinder; | ||
$this->storeManager = $storeManager; | ||
$this->valueFactory = $valueFactory; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls remove using Factory
# Conflicts: # app/code/Magento/UrlRewriteGraphQl/Model/Resolver/UrlRewrite.php
# Conflicts: # app/code/Magento/UrlRewriteGraphQl/Model/Resolver/UrlRewrite.php # app/code/Magento/UrlRewriteGraphQl/etc/schema.graphqls
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added URL rewrites data to the GraphQL product interface. So, now we have a possibility to fetch all URL rewrites for a product with request URL data and target URL parameters.
Also, the old
UrlRewrite
resolver has been renamed toEntityUrl
to make the class name match its purpose.Fixed Issues (if relevant)
Manual testing scenarios