Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Corrected Mutation Query for SetShippingMethodsOnCartTest #467

Conversation

yogeshsuhagiya
Copy link
Member

@yogeshsuhagiya yogeshsuhagiya commented Mar 12, 2019

Description (*)

Coveraged the following Test Cased of SetShippingMethodsOnCartTest for Guest

  • testShippingMethodWithVirtualProduct
  • testShippingMethodWithSimpleProduct
  • testShippingMethodWithSimpleProductWithoutAddress
  • testSetShippingMethodWithMissedRequiredParameters
  • testSetNonExistentShippingMethod
  • testSetShippingMethodIfAddressIsNotBelongToCart
  • testSetShippingMethodToNonExistentCart
  • testSetShippingMethodToGuestCart
  • testSetShippingMethodToAnotherCustomerCart
  • testSetShippingMethodToNonExistentCartAddress
  • testSetShippingMethodToGuestCartAddress
  • testSetShippingMethodToAnotherCustomerCartAddress
  • testSetMultipleShippingMethods

Created a ApiDataFixture rollback for simple_product.php
Applied rollback of simple product, virtual product, customer & customer address in following related files:

  • quote_with_simple_product_saved_rollback.php
  • quote_with_virtual_product_and_address_rollback.php
  • quote_with_virtual_product_saved_rollback.php

Fixed Issues (if relevant)

  1. Test coverage: SetShippingMethodsOnCartTest for Guest #422: Test coverage: SetShippingMethodsOnCartTest for Guest

Manual testing scenarios (*)

  1. N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@naydav
Copy link
Contributor

naydav commented Mar 12, 2019

@yogeshsuhagiya
Task suppose that need to implement all of the tests which marked as incomplete now.
Would you like to continue with this ticket?

@yogeshsuhagiya
Copy link
Member Author

Hi @naydav
Yes, I like to continue with this ticket and currently working on it.

@yogeshsuhagiya
Copy link
Member Author

yogeshsuhagiya commented Mar 15, 2019

Hi @naydav ,
The Codacy throws the following issues:

"require" statement detected. File manipulations are discouraged.
"require" statement detected. File manipulations are discouraged. Concatenating is forbidden.

Do I've to fix those? It's not allowing require statement.

@yogeshsuhagiya
Copy link
Member Author

Hi @naydav, I've applied fixes as per your instruction. Can you please take a look and let me know the further modification if requires? I'll do my best.

@ghost
Copy link

ghost commented Mar 30, 2019

Hi @yogeshsuhagiya, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants