This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 154
Corrected Mutation Query for SetShippingMethodsOnCartTest #467
Merged
magento-engcom-team
merged 11 commits into
magento:2.3-develop
from
yogeshsuhagiya:2.3-develop-graphql-PR-yogesh-5
Mar 30, 2019
Merged
Corrected Mutation Query for SetShippingMethodsOnCartTest #467
magento-engcom-team
merged 11 commits into
magento:2.3-develop
from
yogeshsuhagiya:2.3-develop-graphql-PR-yogesh-5
Mar 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@yogeshsuhagiya |
Hi @naydav |
Hi @naydav ,
Do I've to fix those? It's not allowing require statement. |
…aphql-PR-yogesh-5
naydav
suggested changes
Mar 25, 2019
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetShippingMethodsOnCartTest.php
Outdated
Show resolved
Hide resolved
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetShippingMethodsOnCartTest.php
Outdated
Show resolved
Hide resolved
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetShippingMethodsOnCartTest.php
Outdated
Show resolved
Hide resolved
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetShippingMethodsOnCartTest.php
Outdated
Show resolved
Hide resolved
dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetShippingMethodsOnCartTest.php
Outdated
Show resolved
Hide resolved
...s/integration/testsuite/Magento/Checkout/_files/quote_with_simple_product_saved_rollback.php
Show resolved
Hide resolved
Hi @naydav, I've applied fixes as per your instruction. Can you please take a look and let me know the further modification if requires? I'll do my best. |
…ogesh-5' into 2.3-develop-graphql-PR-yogesh-5
…aphql-PR-yogesh-5
…aphql-PR-yogesh-5
Hi @yogeshsuhagiya, thank you for your contribution! |
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Coveraged the following Test Cased of
SetShippingMethodsOnCartTest
for GuestCreated a
ApiDataFixture
rollback forsimple_product.php
Applied rollback of simple product, virtual product, customer & customer address in following related files:
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)