-
Notifications
You must be signed in to change notification settings - Fork 154
Added createCustomerGraphQl plugin #763
Added createCustomerGraphQl plugin #763
Conversation
app/code/Magento/CustomerGraphQl/Model/Plugin/Customer/CreateCustomerAccount.php
Outdated
Show resolved
Hide resolved
app/code/Magento/CustomerGraphQl/Model/Resolver/CreateCustomer.php
Outdated
Show resolved
Hide resolved
dev/tests/integration/testsuite/Magento/Customer/_files/customer_subscribe.php
Outdated
Show resolved
Hide resolved
Hi @naydav, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace the core usage Magento\Newsletter\Observer\PredispatchNewsletterObserver
with your implementation and remove unnecessary dependency.
*/ | ||
public function __construct( | ||
\Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig, | ||
\Magento\Config\Model\ResourceModel\Config $resourceConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a redundant dependency.
@sedonik, how is your progress with this ticket, are you interested to finish it? |
Co-Authored-By: Lena Orobei <[email protected]>
Co-Authored-By: Lena Orobei <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove redundant fixtures and use @magentoConfigFixture
instead.
Once it is fixed, please squash all commits into one. Thanks. |
…_subscribe_rollback.php
Hi @lenaorobei, |
@sedonik need to check |
Hi @lenaorobei, thank you for the review. |
Hi @sedonik, thank you for your contribution! |
Description
Added Magento\CustomerGraphQl\Model\Plugin\Customer\CreateCustomerAccount
Added createCustomerGraphQl plugin to di.xml
Fixed Issues
Manual testing scenarios
Response
Contribution checklist