Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to select a store using pickup-location-services.js::getLocation(sourceCode) #3209 #3237

Merged
merged 2 commits into from
Nov 14, 2020
Merged

Unable to select a store using pickup-location-services.js::getLocation(sourceCode) #3209 #3237

merged 2 commits into from
Nov 14, 2020

Conversation

maxlussier
Copy link
Contributor

@maxlussier maxlussier commented Nov 7, 2020

Description (*)

Fixed issue with updating the search criteria with the correct parameters.

Fixed Issues (if relevant)

  1. Fixes Unable to select a store using pickup-location-services.js::getLocation(sourceCode) #3209: Unable to select a store using pickup-location-services.js::getLocation(sourceCode)

Manual testing scenarios (*)

  1. Add new sources and make them pickup locations enabled
  2. Create a uiComponent that has a requireJS dependency on Magento_InventoryInStorePickupFrontend/js/model/pickup-locations-service.js and add that uiComponent to the checkout JS layout
  3. The uiComponent should at least contains this code:
pickupLocationsServices.getLocation('X1DF').always(function(location) {
    console.log(location);
});
  1. You should see the location object in your browser's console.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…tLocation(sourceCode) - fixed issue with updating the search criteria with the correct parameters.
…tLocation(sourceCode) - fixed issue with the actual result of serviceUrl ajax response.
@maxlussier
Copy link
Contributor Author

@magento run all tests

@maxlussier
Copy link
Contributor Author

Integration tests Allure Reporting show no failures. Could someone help me figured it out?
Thanks in advance!

@novikor
Copy link
Contributor

novikor commented Nov 9, 2020

@magento run Integration Tests

Copy link
Contributor

@novikor novikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @maxlussier . Thank you for your contribution, we appreciate that.

@sidolov
Copy link
Contributor

sidolov commented Nov 9, 2020

@magento import pr to magento-commerce/inventory

@magento-engcom-team
Copy link
Contributor

@sidolov the pull request successfully imported.

@maxlussier
Copy link
Contributor Author

Hi @novikor! Is there something else I need to do now that the PR has been approved? Are there next steps?

@novikor
Copy link
Contributor

novikor commented Nov 10, 2020

Hi, @maxlussier. The PR has been added to the delivery queue and will be merged as soon as it is possible.
It means that the only thing we can do on our side is just to relax and wait, no any efforts are required😀

@mmansoor-magento mmansoor-magento merged commit 3212ce6 into magento:1.2-develop Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to select a store using pickup-location-services.js::getLocation(sourceCode)
5 participants