Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't search for products with ampersand #10355

Closed
cosmomathieu opened this issue Jul 27, 2017 · 23 comments
Closed

Can't search for products with ampersand #10355

cosmomathieu opened this issue Jul 27, 2017 · 23 comments
Labels
Component: Search Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. stale issue

Comments

@cosmomathieu
Copy link

cosmomathieu commented Jul 27, 2017

We have an item called "Ro & De Black Faux Leather Panel Top." When searching for Ro & De it is finding no results even though it exists. If I search for "Ro" it finds nothing. I have to search for at least "Ro & De Black Faux." Cannot search for this item by brand because it cannot find results.

Preconditions

  1. Magento 2.4-develop

Steps to reproduce

  1. Go to storefront and search for "Ro & De" then search for "Ro & De Black Faux Leather"

Expected result

  1. Product Ro & De Black Faux Leather should show

Actual result

  1. No result is found
@cosmomathieu
Copy link
Author

Nothing, really?

@korostii
Copy link
Contributor

Yes, really. Things move rather slow around here.
There's more than 2000 open issues in here and processing them takes quite a lot of time.
There are older bugs which have been here for months. Some of the 2.1 bugs even managed to pass the one-year mark recently, so you shouldn't be surprised, really.

If the issue is blocking an urgent project for you something like that, you might have better chances trying to fix it yourself.
(And if you do manage to do that, PRs are welcome here, it is an open source project, after all.)

@orlangur
Copy link
Contributor

@korostii how is your comment useful? Why you spend your time on writing such comments instead of something useful? (like, raise topic regarding processes/release strategy/bug triage and so on in appropriate place)

@cosmointeractive to me this issue looks pretty similar to #10176 (comment), try to tune full-text search engine or other suggested solutions.

@korostii
Copy link
Contributor

korostii commented Aug 18, 2017

@orlangur
Well, hello. Long time no see.

how is your comment useful?

For one, it explains that the issue probably wasn't simply overlooked as a unique case, but rather that the waiting time on this repository is quite high, on average.
I find that keeping people well informed about progress (or rather, absence or progress), future plans (or absence of such) lowers down the anxiety and helps to adjust their expectation.
Feeling ignored is not a good feeling, you know.

Like, for example, if you look at mine older comments or @andidhouse's comments, you'll see that a lot of people expect the Magento, Inc. to put some effort into issue management, including but not limited to:

  1. Providing clear timespans for Long-Time Support, similar to what PHP did, for example: http://php.net/supported-versions.php
    Having clear release, end-of-life dates and guaranteed support periods helps merchants and module developers plan their projects and other endeavors in a more predictable manner.
    Like, for, example, you probably wouldn't waste resources starting a new project based on 2.1 if you knew 2.2 is scheduled to get released in a month and 2.1 will only receive security fixes after that.
  2. Active bugfixing, at least for the current latest stable branch (2.1 at the moment). Active as in "major acknowledged issues fixed in order of weeks (and not months)".
  3. Active support, as in "reported issues get a meaningful response in order of days (and not weeks)".
  4. Clear and publicly explained rules, as in "there is no customer support provided for CE users, yet EE users are entitled to priority treatment" etc.

The idea is that Magento is open-core and thus its commercial product (such as Magento EE and Magento B2B) will also benefit from code quality and bugfixes delivered to the core in scope of supporting CE. Thus it is presumed to be beneficial for Magento, Inc. to take user input into account and put some effort into improving the product core (and not just creating more EE and B2B modules), as well.

Thus some people expect to be appreciated and not to ignored when voluntarily submitting issues and suggested improvements.

Having those expectations met with 22 days of silence might be soul-crushing, and even a response that doesn't provide an immediate solution might turn out to be useful, don't you agree?

@cosmomathieu
Copy link
Author

@korostii Thanks your comment was most useful.

@orlangur It was helpful to know that things move slow around these parts. Thanks.

@magento-engcom-team magento-engcom-team added G1 Passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Sep 27, 2017
@magento-engcom-team
Copy link
Contributor

@cosmointeractive, thank you for your report.
We've created internal ticket(s) MAGETWO-80183 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Sep 27, 2017
@orlangur
Copy link
Contributor

@maghamed you may be interested in reviewing this (similar to previous one #10355 (comment)).

@manuelson
Copy link
Contributor

manuelson commented Oct 9, 2017

@okorshenko can you assign to me?

@okorshenko
Copy link
Contributor

Sure. Please accept the invitation on the GitHub

@manuelson
Copy link
Contributor

@okorshenko done!

@adamsimonini
Copy link

@cosmomathieu it might have something to do with the ampersand. I am currently have troubles with it myself. Try removing &, and replacing it with something else that isn't a single character.

@Ravii0
Copy link

Ravii0 commented Jul 18, 2018

We have the same issue on 2.2.5

@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2019

Hi @engcom-Delta. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@engcom-Delta engcom-Delta added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 24, 2019
@ghost ghost unassigned engcom-Delta Dec 24, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets MC-30058 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Dec 24, 2019
@sdzhepa sdzhepa added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Sep 23, 2020
@stale
Copy link

stale bot commented Dec 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Thank you for your contributions.

@magento-engcom-team
Copy link
Contributor

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

Please feel free to comment or reopen according to the Issue reporting guidelines
the ticket if you are still facing this issue on the latest 2.x-develop branch. Thank you for collaboration.

@magento-engcom-team magento-engcom-team removed the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Search Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. stale issue
Projects
Development

No branches or pull requests