Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sku => Entity_id relations are fetched inefficiently when inserting attributes values during product import #10920

Closed
diwipl opened this issue Sep 17, 2017 · 2 comments
Closed

Sku => Entity_id relations are fetched inefficiently when inserting attributes values during product import #10920

diwipl opened this issue Sep 17, 2017 · 2 comments
Assignees
@nmalevanec
Labels
Component: ImportExport Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@diwipl
Copy link

diwipl commented Sep 17, 2017

Product import is not fetching relation between products sku and entity_id efficiently when inserting attributes data.

Preconditions

  1. Magento 2.1.9

Steps to reproduce

  1. Run import of products from sample csv

Expected result

  1. All relations are loaded using one query per bunch

Actual result

  1. Relations are loaded one by one (multiple times for multiple attributes types)

screen shot 2017-09-17 at 13 35 00
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 17, 2017
@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 19, 2017
@nmalevanec nmalevanec self-assigned this Oct 24, 2017
@nmalevanec nmalevanec mentioned this issue Oct 25, 2017
Merged
4 tasks
@okorshenko
Copy link
Contributor

The issue has been fixed in 2.2-develop branch. Will be available with 2.2.2 release

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Nov 9, 2017
@magento-team
Copy link
Contributor

Hi @diwipl. Thank you for your report.
The issue has been fixed in magento-engcom/magento2ce#1287 by @magento-engcom-team in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming patch release.

@magento-team magento-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nmalevanec nmalevanec

Labels
Component: ImportExport Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@magento-team @dmanners @diwipl @okorshenko @nmalevanec @magento-engcom-team